Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --catch-exceptions causing a segfault in Python 3.5. #1173

Closed
wants to merge 1 commit into from

Conversation

johnnyg
Copy link
Contributor

@johnnyg johnnyg commented Feb 3, 2016

This bug arose due to the fact that the traceback module was overhauled
in python 3.5: https://hg.python.org/cpython/rev/73afda5a4e4c
The crash was due to PyTuple_GetItem returning NULL as a traceback is
no longer a list of tuples but rather a list of objects (which support indexing).

This bug arose due to the fact that the traceback module was overhauled
in python 3.5: https://hg.python.org/cpython/rev/73afda5a4e4c
The crash was due to PyTuple_GetItem returning NULL as a traceback is
no longer a list of tuples but rather a list of objects (which support indexing).
@unbit
Copy link
Owner

unbit commented Feb 3, 2016

The patch looks good, i need only to check it for python 2.4 (we still support it)

@johnnyg
Copy link
Contributor Author

johnnyg commented Feb 3, 2016

Yeah I wasn't sure what the earliest version of Python was that you supported.
As far as I can't tell it from the code/docs, the sequence API existed in 2.4 (https://docs.python.org/release/2.4.4/api/sequence-structs.html) so this patch should work in 2.4 but obviously actually testing is the best way to check.

@xrmx
Copy link
Collaborator

xrmx commented Sep 8, 2024

Merged in #2672, thanks!

@xrmx xrmx closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants