Skip to content

Commit

Permalink
core/lock: silence glibc warnings against pthread robust mutex functions
Browse files Browse the repository at this point in the history
Since glibc 2.34 we are gettings warnings that pthread_mutexattr_setrobust_np
and pthread_mutex_consistent_np are deprecated.
Problem is that we are checking PTHREAD_MUTEX_ROBUST with the
preprocessor but it doesn't work because it's an enum :) So in the end
we are using the _np versions of the functions even if the standard ones
are available. Since this stuff is implemented on linux libc since
2010-2011 and 2016 in freebsd assume it's here.
  • Loading branch information
xrmx committed Jul 25, 2023
1 parent 59b3d55 commit d94f6db
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions core/lock.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@ struct uwsgi_lock_item *uwsgi_lock_fast_init(char *id) {
}

#ifdef EOWNERDEAD
#ifndef PTHREAD_MUTEX_ROBUST
#define PTHREAD_MUTEX_ROBUST PTHREAD_MUTEX_ROBUST_NP
#define pthread_mutexattr_setrobust pthread_mutexattr_setrobust_np
#define pthread_mutex_consistent pthread_mutex_consistent_np
#endif
if (uwsgi_pthread_robust_mutexes_enabled) {
int ret;
if ((ret = pthread_mutexattr_setprotocol(&attr, PTHREAD_PRIO_INHERIT)) != 0) {
Expand Down

0 comments on commit d94f6db

Please sign in to comment.