Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
log.Fatal(msg, err)
messages are actually missing theerr
in the logs.For this code
I expected to see something like this in the output (which is what we get with this patch)
but instead I found this
I noticed it works just fine for log.Error, and the only difference was the missing "...", causing the arguments slice to be interpreted as the first argument.
Please read using git and⤵️ before submitting code. (It's at the bottom of the page)
contributing guidelines