feat: disallow import chunkname w/ webpack eager mode #100
Conversation
🦋 Changeset detectedLatest commit: 2cbdc61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
SukkaW
force-pushed
the
backport-webpack-eager
branch
from
6a20bf7
to
28301db
Compare
SukkaW
force-pushed
the
backport-webpack-eager
branch
from
28301db
to
dd2929b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 96.22% 96.14% -0.09%
==========================================
Files 91 91
Lines 4399 4432 +33
Branches 1497 1510 +13
==========================================
+ Hits 4233 4261 +28
- Misses 160 165 +5
Partials 6 6 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SukkaW
force-pushed
the
backport-webpack-eager
branch
from
8d746c2
to
e8ef8cb
Compare
SukkaW
force-pushed
the
backport-webpack-eager
branch
from
e8ef8cb
to
b3068d4
Compare
| @@ -69,9 +78,12 @@ | |||
|
|
|||
| const paddedCommentRegex = /^ (\S[\S\s]+\S) $/ | |||
| const commentStyleRegex = | |||
| /^( ((webpackChunkName: .+)|((webpackPrefetch|webpackPreload): (true|false|-?\d+))|(webpackIgnore: (true|false))|((webpackInclude|webpackExclude): \/.*\/)|(webpackMode: ["'](lazy|lazy-once|eager|weak)["'])|(webpackExports: (["']\w+["']|\[(["']\w+["'], *)+(["']\w+["']*)]))),?)+ $/ | |||
| const chunkSubstrFormat = ` webpackChunkName: ["']${webpackChunknameFormat}["'],? ` | |||
| /^( (((webpackChunkName|webpackFetchPriority): .+)|((webpackPrefetch|webpackPreload): (true|false|-?\d+))|(webpackIgnore: (true|false))|((webpackInclude|webpackExclude): \/.*\/)|(webpackMode: ["'](lazy|lazy-once|eager|weak)["'])|(webpackExports: (["']\w+["']|\[(["']\w+["'], *)+(["']\w+["']*)]))),?)+ $/ | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression High
| @@ -69,9 +78,12 @@ | |||
|
|
|||
| const paddedCommentRegex = /^ (\S[\S\s]+\S) $/ | |||
| const commentStyleRegex = | |||
| /^( ((webpackChunkName: .+)|((webpackPrefetch|webpackPreload): (true|false|-?\d+))|(webpackIgnore: (true|false))|((webpackInclude|webpackExclude): \/.*\/)|(webpackMode: ["'](lazy|lazy-once|eager|weak)["'])|(webpackExports: (["']\w+["']|\[(["']\w+["'], *)+(["']\w+["']*)]))),?)+ $/ | |||
| const chunkSubstrFormat = ` webpackChunkName: ["']${webpackChunknameFormat}["'],? ` | |||
| /^( (((webpackChunkName|webpackFetchPriority): .+)|((webpackPrefetch|webpackPreload): (true|false|-?\d+))|(webpackIgnore: (true|false))|((webpackInclude|webpackExclude): \/.*\/)|(webpackMode: ["'](lazy|lazy-once|eager|weak)["'])|(webpackExports: (["']\w+["']|\[(["']\w+["'], *)+(["']\w+["']*)]))),?)+ $/ | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression High
SukkaW
force-pushed
the
backport-webpack-eager
branch
from
b3068d4
to
2cbdc61
Compare
Backport import-js#3004