Gimbal controls publish with WASD, allow simultaneous key presses #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amszuch
requested review from
jnnanni,
tabiosg,
sashreek1 and
CameronTressler
tabiosg
requested changes
Sep 28, 2022
CameronTressler
requested changes
Sep 28, 2022
jnnanni
reviewed
Sep 28, 2022
| }, | ||
|
|
||
| created: function () { | ||
| document.addEventListener('keydown', this.keymonitordown); |
There was a problem hiding this comment.
You probably don't need these event listener declarations here since you already use v-on statements in the template section
There was a problem hiding this comment.
Having issues with v-on event listeners, keeping both for now
jnnanni
reviewed
Sep 28, 2022
| this.publish() | ||
| }, | ||
|
|
||
| keymonitorup: function(event) { |
There was a problem hiding this comment.
Would be great if you could add some quick comments above keymonitor functions, just to explain why they are written the way they are.
jnnanni
requested changes
Sep 28, 2022
jnnanni
approved these changes
Oct 25, 2022
CameronTressler
approved these changes
Oct 25, 2022
|
Yes, it was tested with echo after the most recent changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #N/A
What features did you add, bugs did you fix, etc?
Adapted WASD controls for gimbal from last year. Now, multiple keys can be pressed simultaneously, and data is sent as an int for left-right (A,D) or up-down (W,S), as either -1 (left, down), 1 (right, up), or 0 (noop). Opposing keys neutralize each other, and we can have non-zero values in both axes.
Did you add documentation to the wiki?
No, I assume we already know gimbal is controlled by WASD
How was this code tested?
Integrated into temp controls GUI and rostopic echoed to check for expected behavior
Did you test this in sim?
No
Did you test this on the rover?
No
Did you add unit tests?
No