Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse calibration lut && include kersten recalibration #184

Merged
merged 13 commits into from
Jan 9, 2024

Conversation

vincelhx
Copy link
Collaborator

No description provided.

Copy link
Member

@agrouaze agrouaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happend if I apply this function to a SLC product?
reading the code, it seems to only print a warning. Why not a raise Error ?

@agrouaze agrouaze added the enhancement New feature or request label Nov 22, 2023
@vincelhx
Copy link
Collaborator Author

yes at this point it shoud raise an Error

@vincelhx
Copy link
Collaborator Author

vincelhx commented Dec 6, 2023

Hi. Now it raises an Error

@agrouaze
Copy link
Member

@vincelhx Is possible to add the xsar.open_dataset times from develop branch and the ones from your branch with and without recalibration applied?
Is your re-calibration working for WV, SM ,EW too ?

@vincelhx
Copy link
Collaborator Author

vincelhx commented Dec 11, 2023

its working for GRD only : i add an exception?
what do you mean by xsar.open_dataset̀ times?

@agrouaze
Copy link
Member

agrouaze commented Dec 12, 2023

its working for GRD only : i add an exception?

WV cannot be produced as GRD but SM and EW are available in GRD, so I guess that re-calibration should work the same way for all acquisition modes. Correct? It is not the case or if it is not yet implemented we need to clarify it in the code and in the doc.

what do you mean by xsar.open_dataset̀ times?

I simply mean the time that opening a product takes, to comapre before/after with/without your re-calibration.

@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 5, 2024

to open a new recalibrated dataset :
s1ds_recal = xsar.Sentinel1Dataset(L1_path,resolution='1000m',recalibration=True)

if no roll angle ( no recalibration ) => ValueError: Recalibration can't be done without roll angle. You probably work with an old file for which roll angle is not auxiliary file.

only for EW/IW

@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 5, 2024

var concerned : INTEREST_VAR = ["sigma0_raw","gamma0_raw","beta0_raw"] (l660 from sentinel1_dataset.py)

@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 5, 2024

no change in .dataset :
excepted an attribute to comment if recalib was applied or not
image

@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 5, 2024

new datatree related to recalibration steps :
maybe it need to be completed or detailed.

image

@vincelhx vincelhx changed the title reverse calibration lut reverse calibration lut && include kersten recalibration Jan 9, 2024
@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 9, 2024

mean times to xsar.Sentinel1Dataset(L1_path, resolution = '1000m')

before commit without recalibration :
Mean time for S1A_IW_GRDH_1SDV_20141231T150741_20141231T150810_003965_004C59_FA9B : 4.936 secondes
Mean time for S1B_EW_GRDM_1SDV_20190306T135326_20190306T135430_015234_01C808_DE3D : 4.156 secondes

after commit without recalibration :
Mean time for S1A_IW_GRDH_1SDV_20141231T150741_20141231T150810_003965_004C59_FA9B : 4.525 secondes
Mean time for S1B_EW_GRDM_1SDV_20190306T135326_20190306T135430_015234_01C808_DE3D : 6.172 secondes
this is due to changes in xarray-safe-s1 umr-lops/xarray-safe-s1#15

after commit with recalibraton
S1A_IW_GRDH_1SDV_20141231T150741_20141231T150810_003965_004C59_FA9B : error (old file)
Mean time for S1B_EW_GRDM_1SDV_20190306T135326_20190306T135430_015234_01C808_DE3D : 6.067 secondes

Vincent LHEUREUX added 2 commits January 9, 2024 11:18
src/xsar/sentinel1_dataset.py Outdated Show resolved Hide resolved
src/xsar/utils.py Outdated Show resolved Hide resolved
src/xsar/sentinel1_meta.py Show resolved Hide resolved
src/xsar/sentinel1_dataset.py Outdated Show resolved Hide resolved
src/xsar/sentinel1_dataset.py Outdated Show resolved Hide resolved
@agrouaze agrouaze merged commit f22b6dc into umr-lops:develop Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants