使“umi block add” 命令可以添加局域网内搭建gitlab #2559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
因为局域网内搭建的gitlab通常都是以IP地址开头，并没有域名，通过正则过滤部分添加了IP地址的过滤来使IP地址开头的gitlab地址也能符合isGitUrl()
afc163
reviewed
Jun 17, 2019
| // or http://192.168.1.11/bigfish/bigfish-blocks/tree/master/demo | ||
| // or http://192.168.1.11/bigfish/testblocks/tree/master | ||
| // or http://192.168.1.11/bigfish/testblocks | ||
| const gitSiteParser = /^(https\:\/\/|http\:\/\/|git\@)((github[\.\w\-]+|gitlab[\.\w\-]+|((25[0-5]|2[0-4]\d|[01]?\d\d?)\.){3}(25[0-5]|2[0-4]\d|[01]?\d\d?)))(\/|\:)([\w\-]+)\/([\w\-]+)(\/tree\/([\w\.\-]+)([\w\-\/]+))?(.git)?$/; |
There was a problem hiding this comment.
建议用 https://www.npmjs.com/package/git-url-parse 重构，这样能解决各种情况。
|
感觉这么加，这个条件都没什么作用了，直接去掉都更好的。 |
|
same with #2245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
因为局域网内搭建的gitlab通常都是以IP地址开头，并没有域名，通过正则过滤部分添加了IP地址的过滤来使IP地址开头的gitlab地址也能符合isGitUrl()