Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade chrome version #8

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

xoxwgys56
Copy link

  • serverless-chrome v1.0.0-37 to v1.0.0-55
  • chromedriver 2.37 to 2.43

also applied changed version on README and add chromium binary version

- serverless-chrome v1.0.0-37 to v1.0.0-55
- chromedriver 2.37 to 2.43

also applied changed version on README and add chromium binary version
@umihico umihico merged commit af995cb into umihico:main Jun 9, 2021
@umihico
Copy link
Owner

umihico commented Jun 9, 2021

@xoxwgys56
Thank you! I created a new release.
https://github.com/umihico/docker-selenium-lambda/releases/tag/v5

@umihico
Copy link
Owner

umihico commented Jun 9, 2021

@xoxwgys56
After I merged yours, I didn't find your name as a contributor. It is might be because your commit is created by dwkim which is your local git config. This link might solve the situation.

https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/managing-email-preferences/adding-an-email-address-to-your-github-account
https://docs.github.com/en/github/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user

@xoxwgys56
Copy link
Author

@umihico Thanks I checked and add dwkim. but It is not applied as contributor so sad..

@umihico
Copy link
Owner

umihico commented Jun 9, 2021

@xoxwgys56
Yeah your commit has now your profile pic. I don’t get why. Maybe past stuff are not recalculated? Sorry

@xoxwgys56
Copy link
Author

@umihico Yes it is. After time I try another contribute. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants