Documentation: Include a history of UMD and when/why to use it #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DanKaplanSES
commented
Oct 13, 2023
DanKaplanSES
commented
- This information is from @bergus and their answer to the question, "What is the Universal Module Definition (UMD)?": https://stackoverflow.com/a/77284527/61624 The linked question explains the motivation for this addition.
- See issue Include a history of UMD and when/why to use it #143
- This information is from @bergus and their answer to the question, "What is the Universal Module Definition (UMD)?": https://stackoverflow.com/a/77284527/61624 The linked question explains the motivation for this addition.
DanKaplanSES
changed the title
|
@addyosmani / @EvanCarroll : Hello! Sorry for the ping, but I was wondering if I could receive feedback on my PR? Thanks! PS: If I can help in anyway, I'd be interested in reviewing the other issues and PRs of the repository. How would one go about getting write access? |
TheGiraffe3
approved these changes
Nov 23, 2024
|
You don't need to have write access to review pull requests; as I did above; but to merge them you do need access. |
|
@addyosmani you've been active elsewhere, could you please review this? |
|
Hey folks. After reading through this LGTM. I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.