feat(sscheck): Sample_Name Check #890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,6 +108,14 @@ def check_sample_name_format(self): | |||
| logger.error("Sample ID {} did not have corresponding Sample_Name".format(self.sample_id)) | |||
| raise SampleNameFormatError | |||
|
|
|||
| # Check if the Sample_Name column is the library_id from the Sample_ID column ignoring the "_topup" / "_rerun" | |||
There was a problem hiding this comment.
Mainly this, where it checks if the Sample_Name (which should be the library_id) is the same Sample_ID format (which is {sampleID}_{library_ID})
alexiswl
reviewed
Mar 6, 2025
lib/workload/stateless/stacks/sample-sheet-check/sample-sheet-check-lambda/handler.py
Outdated
Show resolved
Hide resolved
alexiswl
reviewed
Mar 6, 2025
| @@ -108,6 +108,14 @@ def check_sample_name_format(self): | |||
| logger.error("Sample ID {} did not have corresponding Sample_Name".format(self.sample_id)) | |||
| raise SampleNameFormatError | |||
|
|
|||
| # Check if the Sample_Name column is the library_id from the Sample_ID column ignoring the "_topup" / "_rerun" | |||
| clean_unique_id = SAMPLE_REGEX_OBJS["topup"].sub('', self.unique_id) | |||
There was a problem hiding this comment.
I think there's a better way to regex this, will have a closer look in the morning.
alexiswl
reviewed
Mar 6, 2025
...rkload/stateless/stacks/sample-sheet-check/sample-sheet-check-lambda/tests/sample/mock-2.csv
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #883