add lookup_value_regex to allow special char in url #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raylrui
commented
Jan 23, 2025
•
raylrui
commented
- lookup_value_regex = "[^/]+" # to allow id prefix like 'seq.' in the url
- remove prefix when prefix added in "associated_id"
|
I will revert this PR from UI when this PR merge to the Prod, because pord will has issues about api call without this changes here. @williamputraintan |
| @@ -40,7 +41,7 @@ def create(self, request, *args, **kwargs): | |||
|
|
|||
| # Add workflow_run_id to the request data | |||
| mutable_data = request.data.copy() | |||
| mutable_data['association_id'] = seq_orcabus_id | |||
| mutable_data['association_id'] = seq_orcabus_id.split('.')[1] # remove prefix for association_id | |||
There was a problem hiding this comment.
I think the OrcaBusIdField do this already?
There was a problem hiding this comment.
sorry, just miss that, not work before but it works now
williamputraintan
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.