Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sscheck): Better Error Response #883

Open
williamputraintan opened this issue Feb 28, 2025 · 0 comments · May be fixed by #890
Open

feat(sscheck): Better Error Response #883

williamputraintan opened this issue Feb 28, 2025 · 0 comments · May be fixed by #890
Assignees
@williamputraintan

Comments

@williamputraintan
Copy link
Member

williamputraintan commented Feb 28, 2025 •
edited
Loading

  • Sync library_id extraction for each row of the sample sheet. The checking part parses the Sample_ID column (which is {sampleID}_{library_ID}), but the conversion to V2 takes the libraryID from the Sample_Name column.
  • Perhaps a more appropriate error message should also be thrown if the Sample_Name is not matched with Sample_ID

Ref:
https://umccr.slack.com/archives/C94CQMNVA/p1740625700956749
@williamputraintan williamputraintan self-assigned this Feb 28, 2025
@williamputraintan williamputraintan linked a pull request Mar 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamputraintan williamputraintan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sscheck): Sample_Name Check umccr/orcabus
1 participant
@williamputraintan