-
Notifications
You must be signed in to change notification settings - Fork 56
Adjust indent to compensate border #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes visual alignment of toggle icons by adjusting their positioning to account for the 1px border that increases the total width from 18px to 20px. The change ensures icons are properly centered within the toggle component.
- Updates icon positioning calculations to include the 1px border in the total width
- Modifies both checked and unchecked icon positioning for consistent alignment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bjarne
|
@JasonElkin it has been fixed now :) ![]() ![]() |
Description
This add slightly more indent of toggle icons.
Currently it just use
--uui-toggle-size
which is 18px by default, but also have 1px border so a total width of 20px.Before
After
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist