Add DocTypeGridEditor data type configuration connector #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
approved these changes
Jul 9, 2024
ronaldbarendse
deleted the
v4/feature/doctypegrideditor-datatypeconfigurationconnector
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we already provide DocTypeGridEditor support for transferring content via the
DocTypeGridEditorCellValueConnector(to parse nested values and add dependencies, including the used element types), it didn't properly support schema deployment for the Grid layout data type.This PR adds a
DocTypeGridEditorDataTypeConfigurationConnectorthat parses the Grid layout data type configuration and adds dependencies for any allowed element types for each DocTypeGridEditor grid editor. This ensures the element types are deployed first, before this data type is processed, which is required when doing a Grid layout to Block Grid migration (as that needs to know all element types when migrating the data type artifact)...The easiest way to test is to copy over the added file into an Umbraco 8 site with Deploy 4 and DocTypeGridEditor installed, check that the current Grid layout data type doesn't have any dependencies, re-save the data type and check that it now does have all (allowed) element types added as dependencies.