Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the RTE handle inline elements gracefully for JSON #17983

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Jan 14, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #17037

Description

See the linked issue 👍

Testing this PR

Setup the Delivery API to render RTEs as JSON.

Create and publish a document containing an RTE with this content:

<p>What follows from <strong>here</strong> <em>is</em> <a href="#">just</a> a bunch of text.</p>

...you'll likely need to insert it directly into the RTE code editor.

Verify that the Delivery API output for the document has #text elements with single whitespaces between the inline elements (strong, em and a):

image

Copy link
Member

@Zeegaan Zeegaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 🚀

@Zeegaan Zeegaan merged commit 8f42a3a into release/13.6 Jan 15, 2025
12 of 13 checks passed
@Zeegaan Zeegaan deleted the v13/fix/17037-richtext-json-inline-elements branch January 15, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants