Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mistakes in 15.0.0 migrations #17814

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Fix mistakes in 15.0.0 migrations #17814

merged 5 commits into from
Dec 18, 2024

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Dec 13, 2024 •
edited
Loading

In v15.0.0, 2 migrations were introduced that dealt with RTE and Blocks.
ConvertLocalLinks, which has an error regarding the string manipulation of locallinks that results in broken links.
ConvertRichTextEditorProperties, which has RTE markup transformation logic that is not executed on RTE's inside a nested structure (like blocks)

To fix this, this PR

  • Updates the (original) LocalLinkRteProcessor that is ran recursively by the ConvertLocalLinks migration to execute the same markup transformation as ConvertRichTextEditorProperties
  • Fixes LocalLinkProcessor to correctly transform the links
  • Introduces LocalLinkProcessorForFaultyLinks that has a detector and fix for the very specifically identifiable incorrect locallink tags
  • A secondary Migration that runs (a copy) of the locallinks migration (with the 2 fixes incorperated) if the previous migrations have not run yet in the same migration sessions.

@Migaroez Migaroez changed the title Fix ConvertLocalLinks migration and add a new migration in case the o… Fix mistakes in 15.0.0 migrations Dec 18, 2024
@Migaroez Migaroez requested a review from kjac December 18, 2024 10:26
kjac
kjac approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@Migaroez Migaroez merged commit 0a56aaa into v15/dev Dec 18, 2024
26 of 27 checks passed
@Migaroez Migaroez deleted the v15/bugfix/localLinksMigration branch December 18, 2024 14:24
@kjac
Copy link
Contributor

kjac commented Jan 9, 2025

This fixes #17805 😄

@nul800sebastiaan nul800sebastiaan mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Migaroez @kjac @nul800sebastiaan