Dont autopersist in TranslatableEntityHandler #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me but we have got to test it out on existing projects and make sure this doesn't break BC. Otherwise we'll have to bump version to v2. If so, then let's have a talk on what could be improved on the next version 😉 I'll try and free some of my time next week to proof this PR against our recents projects. |
|
And thanks for your work BTW @DjLeChuck! |
|
The readme would also need to be updated to comply /w this PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
TranslatableEntityHandlershould not callpersiston the newly created entity, this job should be done by the developer.When using the
TranslatableCRUDControllerfor Sonata this modification will be transparent because apersistand aflushare already done.Furthermore, in tests, the
persistwas done almost every time so the remaining are fixed and it's now consistent.I'm open to any suggestion, pros or cons!