fix #3083 improve the parseURL function to handle page-relative URLs #3087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3083 I noticed that some of my hash URLs were tracked without including the path. Upon inspection I found out that the
parseURL
implementation included a bug: it resolved againstorigin
and not againsthref
, which means that page-relative URLs coming from pushState are resolved incorrectly.The following links all resolve to the same page:
https://example.com/foo/bar
/foo/bar
../bar
when you're onhttps://example.com/foo/baz
When using
origin
the last one will resolve incorrectly (it will try to go a subfolder higher than the origin), as it should be compared to the current href.This URL resolution is also why pushstate can contain just
#selector=foo
and resolve correctly against the current page.Fixes #3083.