Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for German translation #2923

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

konstantintutsch
Copy link
Contributor

@konstantintutsch konstantintutsch commented Aug 28, 2024

  • Increase consistency of German translation on Events screen

Overlooked this in my last PR. :)

Copy link

vercel bot commented Aug 28, 2024

@konstantintutsch is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@konstantintutsch konstantintutsch changed the title Small fix to German translation Small fix for German translation Aug 28, 2024
@Brawl345
Copy link
Contributor

Brawl345 commented Oct 6, 2024

Just wanted to open a new PR with it but then I saw yours: Can you also please change all singular "Ereigniss" to "Ereignis"?

https://github.com/konstantintutsch/umami/blob/dev/src/lang/de-DE.json#L70-L71

https://github.com/konstantintutsch/umami/blob/dev/src/lang/de-DE.json#L274

@konstantintutsch
Copy link
Contributor Author

@Brawl345 👌

Copy link
Collaborator

@mikecao mikecao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikecao mikecao merged commit a282b7d into umami-software:dev Oct 25, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants