Use init when running in Docker to avoid zombie process #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `start-docker` script is executed, some process is not properly cleaned up and ends up in a zombie state. Using the `init` flag when launching the container runs an init process inside the container that will forward signals to node and reap processes. Fixes: umami-software#1428
|
@bparmentier is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
|
Any chance to see this merged? I rebased my change on dev instead of master. Not sure why the checks failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
start-dockerscript is executed, some process is not properly cleaned up and ends up in a zombie state.Using the
initflag when launching the container runs an init process inside the container that will forward signals to node and reap processes.Fixes: #1428