#2665 fix proposal #2678
Merged
#2665 fix proposal #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maxime-J is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
devarshishimpi
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About #2665,
this PR restores the client-side search from 2.10 (not affected by the issue) under a specific prop,
used for countries, devices, languages, regions and cities (allowing the search of country displayed with them)
For cities and languages, it also leverages functions already available or added in
useFormathook,like it's done in other fields.