Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle message marks on non-64-bit platforms #329

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Handle message marks on non-64-bit platforms #329

merged 1 commit into from
Aug 18, 2024

Conversation

ulyssa
Copy link
Owner

@ulyssa ulyssa commented Aug 18, 2024

This fixes the issue with running the iamb tests on i686 seen in void-linux/void-packages#49652. I initially tried to do this in modalkit, but ended up deciding that usize is really the right type for Cursor and not u64. I've instead done the conversion here by using usize::MAX to make the hash predictably convertible.

@ulyssa ulyssa added this to the v0.0.10 milestone Aug 18, 2024
@ulyssa ulyssa enabled auto-merge (squash) August 18, 2024 08:30
@ulyssa ulyssa merged commit 4fc05c7 into main Aug 18, 2024
4 checks passed
@ulyssa ulyssa deleted the 32-bit-marks branch August 18, 2024 08:31
@ulyssa
Copy link
Owner Author

ulyssa commented Aug 18, 2024

Also, writing down how to run the tests w/ i686 in case I need to do it again in the future:

% sudo apt-get install crossbuild-essential-i386
% CC_i686_unknown_linux_gnu=i686-linux-gnu-gcc CARGO_TARGET_I686_UNKNOWN_LINUX_GNU_LINKER=i686-linux-gnu-gcc \
    cargo test --target i686-unknown-linux-gnu

@ulyssa ulyssa mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant