Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new :chats window that lists both DMs and Rooms #184

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Vaelio
Copy link

@Vaelio Vaelio commented Dec 6, 2023

Hello everyone,

It's my first PR in rust so feel free to criticise.

The PR adds :chats command, listing both DMs and Rooms. I've added a tag [DM] or [ROOM] to make sure we can differenciate if two have the same name.

image

(related to #172 )

@Vaelio
Copy link
Author

Vaelio commented Dec 17, 2023

I didn't catch the typo in the commit until now somehow, sorry for that. The program now compiles.

@ulyssa ulyssa changed the title Features: add :chats window that lists both DMs and Rooms Add a new :chats window that lists both DMs and Rooms Feb 28, 2024
@ulyssa
Copy link
Owner

ulyssa commented Feb 28, 2024

This looks great! Thank you for taking care of #172! I've added it to the SortValues so that people can specifically sort this window, and moved the DM/Room label to be at the beginning of the room tags when they're present.

@ulyssa ulyssa added this to the v0.0.9 milestone Feb 28, 2024
@ulyssa ulyssa merged commit b7ae014 into ulyssa:main Feb 28, 2024
3 checks passed
@ulyssa ulyssa mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants