Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use terminal focus to determine when a message has actually been seen #94

Closed
BeanieBarrow opened this issue May 1, 2023 · 1 comment
Assignees
Milestone

Comments

@BeanieBarrow
Copy link

It has come to my attention that when leaving a room open in my terminal and switching to another window/workspace, any message that gets sent to the room is automatically "seen" by me, even though it isn't.

I don't know if it's possible to check if a terminal gets the focus of the window manager (might be switching stuff up) or not. This bug isn't present when I'm in the room/dm picker menu.

@ulyssa ulyssa changed the title Bug: If a room is open, but the terminal window is not focused, the client still sends a seen message Use terminal window focus to determine when a message has actually been seen May 25, 2023
@ulyssa ulyssa added this to the v0.0.8 milestone May 25, 2023
@ulyssa ulyssa changed the title Use terminal window focus to determine when a message has actually been seen Use terminal focus to determine when a message has actually been seen May 25, 2023
@ulyssa ulyssa self-assigned this May 25, 2023
@ulyssa
Copy link
Owner

ulyssa commented Jun 15, 2023

I've added code to check whether or not the terminal window is focused (for those terminals/multiplexers that support it), and use that to determine whether to update the receipts.

@ulyssa ulyssa closed this as completed Jun 15, 2023
@ulyssa ulyssa mentioned this issue Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants