The cmake Sodium lib crash build

[jose94752]

Crash of the "Windows with cmake, generate Visual Studio project files" No Sodium lib

C:\source\obj>cmake --build . --parallel --config=RelWithDebInfo
Version MSBuild 17.11.9+a69bbaaf5 pour .NET Framework

  1>Checking Build System
  MSLogonACL.vcxproj -> C:\source\obj\MSLogonACL\RelWithDebInfo\MSLogonACL.exe
  ldapauth.vcxproj -> C:\source\obj\ldapauth\RelWithDebInfo\ldapauth.dll
[...]
C:\source\UltraVNC\winvnc\winvnc\SettingsManager.cpp(36,10): error C1083: Impossible d'ouvrir le fichier include : 'sodium.h' : No such file or directory [C:\source\obj\winvnc\winvnc.vcxproj]

c52b72e VCPKG_README.txt exist

With these lines
libsodium:x86-windows-static
libsodium:x86-windows
libsodium:x64-windows-static
libsodium:x64-windows

I propose to fix by update of the on the cmake/readme.txt like theses:

######################

# Debian Trixie/unstable amd64 qemu VM 2024-07-28

[...]

vcpkg install zlib:x64-mingw-static
vcpkg install zstd:x64-mingw-static
vcpkg install libjpeg-turbo:x64-mingw-static
vcpkg install liblzma:x64-mingw-static
vcpkg install openssl:x64-mingw-static
vcpkg install libsodium:x64-mingw-static

[...]

######################

# Windows with cmake, generate Visual Studio project files

[...]

vcpkg install zlib:x64-windows-static
vcpkg install zstd:x64-windows-static
vcpkg install libjpeg-turbo:x64-windows-static
vcpkg install liblzma:x64-windows-static
vcpkg install openssl:x64-windows-static
vcpkg install libsodium:x64-windows-static
[...]

Or the return of the deleted file VCPKG_README.txt not on the root but on the cmake folder.

Nevertheless, after I have been installing the libsodium and integrate, the rebuild is failing (before delete of the folder obj and after delete of obj folder), with the following message.

LINK : warning LNK4098: conflit entre la bibliothèque par défaut 'LIBCMT' et les autres bibliothèques ; utilisez /NODEFAULTLIB:library [C:\source\obj\vncviewer\vncviewer.vcxproj]
  vncviewer.vcxproj -> C:\source\obj\vncviewer\RelWithDebInfo\vncviewer.exe
LINK : fatal error LNK1104: impossible d'ouvrir le fichier 'libsodium.lib' [C:\source\obj\winvnc\winvnc.vcxproj]

[RudiDeVos]

Link Warning
You are mixing Runtime library (option /MT(d)) with /MD all libs and exe need to be the same (MT)
LINK error: the libsodium path is missing.
Normal VCPKG should take care of the paths

Placed a copy of the README in cmake folder

[jose94752]

@RudiDeVos May be I have the problem "You are mixing Runtime library (option /MT(d)) with /MD all libs and exe need to be the same (MT)"
but when I check [C:\source\obj\winvnc\winvnc.vcxproj] source file on my computer no where I find the 'libsodium.lib' file. Is it possible that the vcpkg integrate install command failed on Microsoft Windows ? (Note on Linux we don't use the integrate command on the cmake/readme.txt file)
And for the Runtime library option don't understood where is that command switch.

[Neustradamus]

@jose94752: You have solved the problem?

[jose94752]

@Neustradamus
Sorry, the problem is not solved. I've tried with the delete of obj folder without delete vcpkg folder and I try with again the delete of all folder on source directory except UltraVNC source folder.
I have these for

Windows with cmake, generate Visual Studio project files

the obj folder.

C:\source\UltraVNC\common\mnemonic.c(414,12): warning C4090: '=' : différents qualificateurs 'const' [C:\source\obj\vncviewer\vncviewer.vcxproj]
  d3des.c
  minilzo.c
  vncauth.c
LINK : warning LNK4098: conflit entre la bibliothèque par défaut 'LIBCMT' et les autres bibliothèques ; utilisez /NODEFAULTLIB:library [C:\source\obj\vncvie
wer\vncviewer.vcxproj]
LINK : fatal error LNK1104: impossible d'ouvrir le fichier 'libsodium.lib' [C:\source\obj\winvnc\winvnc.vcxproj]
  vncviewer.vcxproj -> C:\source\obj\vncviewer\RelWithDebInfo\vncviewer.exe

Windows with cmake, using ninja build system, and address santitizer enabled

failed on
cmake --build . --parallel --config=RelWithDebInfo

C:\source\UltraVNC\winvnc\winvnc\vsocket.cpp(2399): warning C4244: 'argument' : conversion de 'SOCKET' en 'int', perte possible de données
[296/297] Linking CXX executable winvnc\winvnc.exe
FAILED: winvnc/winvnc.exe
[...]
LINK : fatal error LNK1104: impossible d'ouvrir le fichier 'libsodium.lib'
[297/297] Linking CXX shared library workgrpdomnt4\workgrpdomnt4.dll
ninja: build stopped: subcommand failed.

Windows with cmake, using LLVM compiler

Work but a have these errors during it compile :

C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1419,12): warning : a function definition without a prototype is deprecated in all versions of C and is not
supported in C2x [-Wdeprecated-non-prototype] [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1637,22): error : call to undeclared function 'inflate_copy'; ISO C99 and later do not support implicit func
tion declarations [-Wimplicit-function-declaration] [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1635,21): message : expanded from macro 'UZinflate' [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxpro
j]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1637,22): message : did you mean 'inflate_free'? [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1635,21): message : expanded from macro 'UZinflate' [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxpro
j]
C:\source\UltraVNC\zipunzip_src\unzip/unzpriv.h(1995,11): message : 'inflate_free' declared here [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1760,12): warning : a function definition without a prototype is deprecated in all versions of C and is not
supported in C2x [-Wdeprecated-non-prototype] [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(2009,5): warning : a function definition without a prototype is deprecated in all versions of C and is not s
upported in C2x [-Wdeprecated-non-prototype] [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(2044,22): error : call to undeclared function 'inflate_copy'; ISO C99 and later do not support implicit func
tion declarations [-Wimplicit-function-declaration] [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxproj]
C:\source\UltraVNC\zipunzip_src\unzip\extract.c(1635,21): message : expanded from macro 'UZinflate' [C:\source\obj_ninja_llvm\libzipunzip\libzipunzip.vcxpro
j]
[...]
C:\source\UltraVNC\zipunzip_src\zip20\win32\win32zip.c(495,5): warning : a function definition without a prototype is deprecated in all versions of C and is
 not supported in C2x [-Wdeprecated-non-prototype] [C:\source\obj_ninja_llvm\libzip32\libzip32.vcxproj]
C:\source\UltraVNC\zipunzip_src\zip20\win32\win32zip.c(658,5): error : call to undeclared function 'printff'; ISO C99 and later do not support implicit func
tion declarations [-Wimplicit-function-declaration] [C:\source\obj_ninja_llvm\libzip32\libzip32.vcxproj]
C:\source\UltraVNC\zipunzip_src\zip20\win32\win32zip.c(658,5): message : did you mean 'printf'? [C:\source\obj_ninja_llvm\libzip32\libzip32.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\ucrt\stdio.h(950,37): message : 'printf' declared here [C:\source\obj_ninja_llvm\libzip32\libzip
32.vcxproj]

Windows with regular Visual Studio project files

Works
msbuild %_P% winvnc\winvnc.sln
423 Warning(s)
0 Error(s)
Elapsed time 00:00:30.93

msbuild %_P% vncviewer\vncviewer.sln
209 Warning(s)
0 Error(s)
Elapsed time 00:00:17.88

[jose94752]

Another try have failed excluded build directories from the antivirus scan
https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk1104?view=msvc-170

I've tried many times and the last time with X64 Terminal and my antivirus disable same error LNK1104: Unable to open 'libsodium.lib' file [C:\source\obj\winvnc\winvnc.vcxproj].
For the X64 Terminal I will explain in next comment.

[jose94752]

I've will be correcting the cmake/readmefile.txt at line 72 because of the message of the compiler mentioning in the pushed files.
Developer Command Prompt for VS
To v
x64 Native Tools Command Prompt for VS 2022

[jose94752]

Error after Adding find_package and target_link_libraries for sodium lib bdbd7fa

vncmenu.obj : error LNK2019: unresolved external symbol "public: __cdecl PropertiesDialog::PropertiesDialog(void)" (??0PropertiesDialog@@QEAA@XZ) referenced in the function "public: __cdecl vncMenu::vncMenu(class vncServer *)" (??0vncMe
nu@@QEAA@PEAVvncServer@@@Z) [C:\source\obj\winvnc\winvnc.vcxproj]
vncmenu.obj : error LNK2019: unresolved external symbol "public: __cdecl PropertiesDialog::~PropertiesDialog(void)" (??1PropertiesDialog@@QEAA@XZ) referenced in the function "int `public: __cdecl vncMenu::vncMenu(class vncServer *)'::`1
'::dtor$0" (?dtor$0@?0???0vncMenu@@QEAA@PEAVvncServer@@@Z@4HA) [C:\source\obj\winvnc\winvnc.vcxproj]
vncmenu.obj : error LNK2019: unresolved external symbol "public: int __cdecl PropertiesDialog::Init(class vncServer *)" (?Init@PropertiesDialog@@QEAAHPEAVvncServer@@@Z) referenced in the function "public: __cdecl vncMenu::vncMenu(class
vncServer *)" (??0vncMenu@@QEAA@PEAVvncServer@@@Z) [C:\source\obj\winvnc\winvnc.vcxproj]
vncmenu.obj : error LNK2019: unresolved external symbol "public: int __cdecl PropertiesDialog::ShowDialog(void)" (?ShowDialog@PropertiesDialog@@QEAAHXZ) referenced in the function "protected: int __cdecl vncMenu::AddNotificationIcon(voi
d)" (?AddNotificationIcon@vncMenu@@IEAAHXZ) [C:\source\obj\winvnc\winvnc.vcxproj]
vncmenu.obj : error LNK2019: unresolved external symbol "public: void __cdecl PropertiesDialog::UpdateServer(void)" (?UpdateServer@PropertiesDialog@@QEAAXXZ) referenced in the function "protected: static __int64 __cdecl vncMenu::WndProc
(struct HWND__ *,unsigned int,unsigned __int64,__int64)" (?WndProc@vncMenu@@KA_JPEAUHWND__@@I_K_J@Z) [C:\source\obj\winvnc\winvnc.vcxproj]
winvnc.obj : error LNK2019: unresolved external symbol "public: static void __cdecl PropertiesDialog::Secure_Plugin_elevated(char *)" (?Secure_Plugin_elevated@PropertiesDialog@@SAXPEAD@Z) referenced in the function WinMain [C:\source\ob
j\winvnc\winvnc.vcxproj]
winvnc.obj : error LNK2019: unresolved external symbol "public: static void __cdecl PropertiesDialog::Secure_Plugin(char *)" (?Secure_Plugin@PropertiesDialog@@SAXPEAD@Z) referenced in the function WinMain [C:\source\obj\winvnc\winvnc.vc
xproj]
C:\source\obj\winvnc\RelWithDebInfo\winvnc.exe : fatal error LNK1120: 7 unresolved external [C:\source\obj\winvnc\winvnc.vcxproj]

Search answer In Progress :
https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk2019?view=msvc-170

[RudiDeVos]

I'm trying to compile it myself with cmake ui without luck. He just stop on files not found..

Looking at the cmake i see that you only add
vcpkg install zlib:x64-windows-static
vcpkg install zstd:x64-windows-static
vcpkg install libjpeg-turbo:x64-windows-static
vcpkg install liblzma:x64-windows-static
vcpkg install openssl:x64-windows-static
vcpkg install libsodium:x64-windows-static

On windows this wasn't working without the install of lib:x64-windows, zstd:x64-windows , liblzma:x64-windows, libsodium:x64-windows, libjpeg-turbo:x64-windows. And i remember also getting a file not found

[RudiDeVos]

vncmenu.obj : error LNK2019: unresolved external symbol "public: __cdecl PropertiesDialog...
This indicate the .h is found but the cpp wasn't compiled ( It could be PropertiesDialog.cpp is missing in the list if files to be compiled)