Fix RTCP SR RTP timestamp value calculation #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTCP SR (and potentially other code) uses rtp::get_rtp_ts() to calculate the RTP SR timestamp value. If push_frame is used with explicit NTP timestamp, get_rtp_ts always returned 0 because the member variable rtp::rtp_ts_ is never assigned. This commit adds the missing assignments.
|
Hi, Looks correct, thanks. Merging. BR, Joni Räsänen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTCP SR (and potentially other code) uses rtp::get_rtp_ts() to calculate the RTP SR timestamp value. If push_frame is used with explicit NTP timestamp, get_rtp_ts() always returnes 0 because the member variable rtp::rtp_ts_ is never assigned. This commit adds the missing assignments.