Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title processing changes #42

Merged
merged 3 commits into from
May 2, 2014
Merged

Conversation

munnja001
Copy link
Contributor

Fixed two bugs which make the inheritance of titles much more natural

1st: If the content did not have a "head" tag, the decorator title would not be processed leaving the title blank. I updated the code to properly process the decorator title when the content head is null

2nd: When either the decorator title or content title are empty, the title pattern is being processed which is resulting in unnatural titles such as "Decorator Title -" instead of "Decorator Title". I updated the code to only process the title pattern if both decorator title and content title are not empty

Thanks for the great plugin!

  • Justin

@ultraq
Copy link
Owner

ultraq commented Apr 28, 2014

Soooooo glad you removed the reliance on Apache's StringUtils - I am not a fan of that library (have been stung by it in the past w/ performance critical code).

Seeing all the 'null or empty' checks though, maybe one day I'll rewrite the thing in Groovy just to keep the whole thing cleaner-looking!

but it is not this day

Anyway, I'm pretty happy with the changes and the general idea behind them. I'll merge them when I get some time to give it all a closer look, hopefully with any fixes to bug reports that might come through, although I'd be happy to release a minor version with just this change too.

ultraq added a commit that referenced this pull request May 2, 2014
@ultraq ultraq merged commit e245757 into ultraq:master May 2, 2014
@ultraq
Copy link
Owner

ultraq commented May 11, 2014

This change is now in version 1.2.4, which was released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants