Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relative ROOT logic #4955

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Update relative ROOT logic #4955

merged 2 commits into from
Sep 28, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 28, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved path handling and argument logging for YOLOv5 models.

πŸ“Š Key Changes

  • πŸ› οΈ Made the root directory paths relative to the current working directory in tf.py and yolo.py.
  • πŸ“ Added print_args function to log command-line argument values when parsing model configurations in yolo.py.

🎯 Purpose & Impact

  • πŸ“‚ Enhanced Path Handling: Converting absolute paths to relative paths helps prevent issues when the working directory changes, making the codebase more robust and portable.
  • πŸ‘€ Better Logging: By introducing argument logging, users and developers can now have a clearer understanding of the configurations being used during model setup and debugging, thus enhancing transparency and ease of troubleshooting.

@glenn-jocher glenn-jocher merged commit 5ed2860 into master Sep 28, 2021
@glenn-jocher glenn-jocher deleted the update/roots branch September 28, 2021 01:26
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
* Update relative `ROOT` logic

* python 3.9 Path().is_relative_to() removal
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Update relative `ROOT` logic

* python 3.9 Path().is_relative_to() removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant