Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DDP destruction LOGGER.info() #4863

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Fix DDP destruction LOGGER.info() #4863

merged 1 commit into from
Sep 20, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 20, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved logging for distributed training cleanup.

πŸ“Š Key Changes

  • Split the logging and cleanup process into two separate lines in train.py.

🎯 Purpose & Impact

  • 🎯 Purpose: Clarifies the logging output by ensuring the 'Destroying process group...' message is logged before the process group is destroyed.
  • 🎯 Impact: This makes it easier for users to understand what is happening during the end of distributed training sessions, especially if an error occurs during the cleanup phase.

@glenn-jocher glenn-jocher merged commit 2b3109e into master Sep 20, 2021
@glenn-jocher glenn-jocher deleted the fix/ddp_destroy branch September 20, 2021 11:12
CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant