Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter: extra_chrome_arguments + dont set window size #1692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Dec 8, 2023

adding a parameter for *every* chrome argument is stupid
so just accept a extra_chrome_arguments list

dont set window size
a 1920x1080 chrome window is too large for my 1024x768 vnc display

@Noodles0x00
Copy link

I am not the original writer for those lines so I can't tell for sure but removing the set window size is a horrible decision, that's just a free digital footprint to be tracked everywhere, horrible when you are trying to make "undetected" chrome

@milahu
Copy link
Author

milahu commented Feb 18, 2024

removing the set window size is a horrible decision

hard-coding a 1920x1080 window size is worse

to manage browser fingerprints
i want to use a custom window size for each fingerprint

undetected-chromedriver should do only the bare minimum
and leave the rest to the user

@ultrafunkamsterdam
Copy link
Owner

Why don't you just use use --window-size=1024x1024 for your program?

@milahu
Copy link
Author

milahu commented Feb 18, 2024

--window-size=1024x1024

if that works, okay, feel free to close this
i cant remember if i tried to pass window-size

i have moved to selenium_driverless
so i dont have to mess with the chromedriver binary

@ultrafunkamsterdam
Copy link
Owner

--window-size=1024x1024

if that works, okay, feel free to close this i cant remember if i tried to pass window-size

i have moved to selenium_driverless so i dont have to mess with the chromedriver binary

Good luck with that spamboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants