Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shemgp/ojs_ldap_plugin#1: Allow for plugin to operate in site or context #1

Closed
wants to merge 1 commit into from
Closed

shemgp/ojs_ldap_plugin#1: Allow for plugin to operate in site or context #1

wants to merge 1 commit into from

Conversation

ctgraham
Copy link
Member

This should allow:

  • The plugin to be enabled/configured in the site context, disallowing settings per context
  • The plugin to be enabled/configured in a specific context (if not at the site)
  • The plugin to act as enabled/configured in the site context, if only one context is present

This could be considered as a partial proof-of-concept for porting into core as part of pkp/pkp-lib#1923 .

@ctgraham ctgraham requested a review from alex-wreschnig July 10, 2019 15:53
@ctgraham
Copy link
Member Author

@alex-wreschnig please review and consider implications w/r/t our recent conversation on formHoneypot.

alex-wreschnig
alex-wreschnig approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@alex-wreschnig alex-wreschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me. I think the changes you're making here to allow for a globally enabled mode are good ones and I don't see any flaws in the logic.

@ctgraham
Copy link
Member Author

Changes proposed upstream: shemgp#3

@ctgraham ctgraham closed this Jul 15, 2019
@ctgraham ctgraham deleted the enable-site-or-context branch April 3, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-wreschnig alex-wreschnig alex-wreschnig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctgraham @alex-wreschnig