fix(core): don’t record recordOutput as command

ulixee · Mar 23, 2022 · e7145d9 · e7145d9
1 parent a111a9e
commit e7145d9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/client/lib/CoreCommandQueue.ts b/client/lib/CoreCommandQueue.ts
@@ -137,7 +137,6 @@ export default class CoreCommandQueue {
     this.internalState.commandsToRecord.push({
       ...command,
       startDate: new Date(),
-      commandId: command?.commandId ?? this.nextCommandId,
     });
     if (this.internalState.commandsToRecord.length > 1000) {
       this.flush().catch(() => null);

diff --git a/core/lib/Session.ts b/core/lib/Session.ts
@@ -237,7 +237,6 @@ export default class Session
       this.getHeroMeta,
       this.addRemoteEventListener,
       this.removeRemoteEventListener,
-      this.recordOutput,
       this.pauseCommands,
       this.resumeCommands,
     ]);
@@ -260,7 +259,7 @@ export default class Session
   }
 
   public isAllowedCommand(method: string): boolean {
-    return this.commandRecorder.fnNames.has(method);
+    return this.commandRecorder.fnNames.has(method) || method === 'recordOutput';
   }
 
   public shouldWaitForCommandLock(method: keyof Session): boolean {

diff --git a/timetravel/lib/MirrorPage.ts b/timetravel/lib/MirrorPage.ts
@@ -163,7 +163,7 @@ export default class MirrorPage extends TypedEventEmitter<{
       this.subscribeToTab = null;
       this.domRecording = null;
       this.isReady = null;
-      // @ts-expect-error
+      // @ts-ignore
       this.loadQueue.reset();
     });
     this.subscribeToTab = tab;