fix(core): don't record removal of donottrack

ulixee · Jan 13, 2022 · d5fd604 · d5fd604
1 parent 573e6f9
commit d5fd604
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/core/injected-scripts/pageEventsRecorder.ts b/core/injected-scripts/pageEventsRecorder.ts
@@ -625,11 +625,6 @@ class PageEventsRecorder {
     if (action === DomActionType.added) {
       this.nodeIdToParentNodeId[serial.id] = serial.parentNodeId;
 
-      // don't include this if it's hero id
-      if (this.doNotTrackElementsById.has(serial.id)) {
-        return;
-      }
-
       if (this.doNotTrackElementsById.has(serial.previousSiblingId)) {
         // get previous node that's tracked
         let previousNode: ChildNode = this.doNotTrackElementsById.get(serial.previousSiblingId);
@@ -641,6 +636,10 @@ class PageEventsRecorder {
         serial.previousSiblingId = nodeId;
       }
     }
+    // don't include this if it's hero id
+    if (this.doNotTrackElementsById.has(serial.id)) {
+      return;
+    }
     this.domChanges.push([action, serial, timestamp, idx()]);
   }
 }