fix: capitalized TODOs

ulixee · Mar 18, 2022 · 01b78f5 · 01b78f5
1 parent 9e73e91
commit 01b78f5
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 7 deletions.
diff --git a/core/injected-scripts/NodeTracker.ts b/core/injected-scripts/NodeTracker.ts
@@ -1,4 +1,4 @@
-function NodeTrackerStatics(constructor: IStaticNodeTracker) {}
+function NodeTrackerStatics(staticClass: IStaticNodeTracker) {}
 
 @NodeTrackerStatics
 class NodeTracker {

diff --git a/core/test/events.test.ts b/core/test/events.test.ts
@@ -59,7 +59,7 @@ describe('Core events tests', () => {
     await tab.goto(`${koaServer.baseUrl}/page2`);
     await tab.waitForLoad(LocationStatus.PaintingStable);
 
-    // ToDo: this should really be 2; it's emitting base document as an resource
+    // TODO: this should really be 2; it's emitting base document as an resource
     expect(onEventFn.mock.calls).toHaveLength(4);
   }, 10e3);
 
@@ -88,7 +88,7 @@ describe('Core events tests', () => {
     await tab.goto(`${koaServer.baseUrl}/page2`);
     await tab.waitForLoad(LocationStatus.PaintingStable);
 
-    // ToDo: this should really be 1; it's emitting base document as an resource
+    // TODO: this should really be 1; it's emitting base document as an resource
     expect(onEventFn.mock.calls).toHaveLength(2);
   }, 10e3);
 });
diff --git a/interfaces/IClientPlugin.ts b/interfaces/IClientPlugin.ts
@@ -23,6 +23,6 @@ export interface IClientPluginClass {
 
 // decorator for client plugin classes. hacky way to check the class implements statics we need
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function ClientPluginClassDecorator(constructor: IClientPluginClass): void {}
+export function ClientPluginClassDecorator(staticClass: IClientPluginClass): void {}
 
 export type ISendToCoreFn = (toPluginId: string, ...args: any[]) => Promise<any>;
diff --git a/interfaces/ICorePlugin.ts b/interfaces/ICorePlugin.ts
@@ -51,7 +51,7 @@ export interface IOnClientCommandMeta {
 }
 
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function CorePluginClassDecorator(constructor: ICorePluginClass): void {}
+export function CorePluginClassDecorator(staticClass: ICorePluginClass): void {}
 
 // HUMAN EMULATORS ///////////////////////////////////////////////////////////////////////////////////////////////////
 
@@ -80,7 +80,7 @@ export interface IHumanEmulatorMethods {
 
 // decorator for human emulator classes. hacky way to check the class implements statics we need
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function HumanEmulatorClassDecorator(constructor: IHumanEmulatorClass): void {}
+export function HumanEmulatorClassDecorator(staticClass: IHumanEmulatorClass): void {}
 
 // BROWSER EMULATORS ///////////////////////////////////////////////////////////////////////////////////////////////////
 
@@ -167,4 +167,4 @@ export type IBrowserEmulatorConfig = Pick<
 
 // decorator for browser emulator classes. hacky way to check the class implements statics we need
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function BrowserEmulatorClassDecorator(constructor: IBrowserEmulatorClass): void {}
+export function BrowserEmulatorClassDecorator(staticClass: IBrowserEmulatorClass): void {}
diff --git a/yarn.lock b/yarn.lock
@@ -2058,6 +2058,15 @@
     progress "^2.0.3"
     tar "^6.1.0"
 
+"@ulixee/commons@1.5.10":
+  version "1.5.10"
+  resolved "https://registry.yarnpkg.com/@ulixee/commons/-/commons-1.5.10.tgz#a29759beffbc9ced7c656a1d80cb0fc6831b2ee9"
+  integrity sha512-HBN1pZ2K/3Ai7HR6zH4Fg5P6klQUUwgmb2e/kWBLLRjwtRLarfNpTJh0xkqGWCiHIAWk4vqNmsRG72rzde/x8Q==
+  dependencies:
+    devtools-protocol "^0.0.799653"
+    https-proxy-agent "^5.0.0"
+    source-map-js "^1.0.1"
+
 JSONStream@^1.0.4:
   version "1.3.5"
   resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.5.tgz#3208c1f08d3a4d99261ab64f92302bc15e111ca0"