-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Do not rewrite links in symlinked files #305
Conversation
@tkoskela I'm not crazy, right? This line after rewriting the links is - [Installation](https://ukri-excalibur.github.io/excalibur-tests/preview/PR305/install/) right? But then the generated website has the duplicate subdir excalibur-tests/preview/PR305/index.html Line 1212 in 5d49476
|
As far as I understand: the link rewriting command is working as intended, but mkdocs sometimes is doing something stupid when generating the HTML files. I say "sometimes" because in #295 it was working correctly. |
c1dca41
to
45e2fdc
Compare
If we rewrite the hyperlinks in symlinked files we risk to accidentally append duplicate `${PREVIEW_SUBDIR}`, depending on the order with which `find` operates on the files.
45e2fdc
to
120e706
Compare
After a long time staring at the screen to spot the error, I believe now I understand the problem: the This probably also explains why the error was occurring occasionally: the occurrence of the error depends on the order with which Note that the links are finally correct in 22d3f8e (triggered by adf2e95) and stayed the same in the three subsequent commits (22d3f8e...3e11c4b) |
If we rewrite the hyperlinks in symlinked files we risk to accidentally append duplicate
${PREVIEW_SUBDIR}
, depending on the order with whichfind
operates on the files.Should fix #304.