Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted case of a proper noun "Elasticsearch" #349

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Fix inverted case of a proper noun "Elasticsearch" #349

merged 1 commit into from
Jan 23, 2018

Conversation

piroor
Copy link
Contributor

@piroor piroor commented Jan 23, 2018

elastic/elasticsearch#4634 changed "ElasticSearch" to "Elasticsearch", but still there are old versions in the README.md. Thus PR finishes #4634.

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible
  • feature works in elasticsearch_dynamic (not required but recommended)

git grep ElasticSearch | cut -d : -f 1 | uniq | xargs sed -r -i -e s/ElasticSearch/Elasticsearch/g '{}'
Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
BTW, this plugin is still maintaining for v0.12.
If you have some time for paying attention this issue, could you send patches same as this PR into v0.12 branch?

@cosmo0920 cosmo0920 merged commit 59c2747 into uken:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants