Fix flash of content on initialization #717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does two things to eliminate the flash, when using the
ReactCodeMirror
component:setContainer
in an effect when thecontainer
prop changessetContainer(null)
-> re-render ->setContainer(el)
-> re-render -> [now component can initialize]props.container
is referentially equal tocontainer
, set by the ref callback when thediv
mountedSo the new set of render cycles on mount is:
mount ->
setContainer
in callback ref -> re-render -> layout effect to initialize editor state -> re-render -> paintIt won't eliminate flashing when users choose to use
useCodeMirror
directly, unless they are also callingsetContainer
in a callback ref on their parent element.Ideally, I think
useCodeMirror
would not take a container prop at all, and would instead do all of the state/view initialization logic insetContainer
, which would be a callback ref. However, this is a breaking change, and I don't want to remove all of the synchronization logic in effects which enables passing a differentcontainer
.