Fix toml-test scripts #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
commented
Oct 10, 2023
| # e=0 | ||
| # toml-test ./tests/decoding_test.py || e=1 | ||
| # toml-test -encoder ./tests/encoding_test.py || e=1 | ||
| # exit $e |
There was a problem hiding this comment.
Didn't test this bit, but should be alright. You can add expected test failures with something like:
skip_dec=(
-skip test1
-skip test2
)
toml-test -skip $skip_dec[@] ./tests/decoding_test.py || e=1
Generate a list with something like:
toml-test -color never ./tests/decoding_test.py |& grep -a FAIL | sed 's/FAIL/-skip/'
uiri
reviewed
Oct 10, 2023
tests/decoding_test.py
Outdated
| return {'type': 'string', 'value': value} | ||
| elif isinstance(value, bool): | ||
| return {'type': 'bool', 'value': str(value).lower()} | ||
| elif isinstance(value, int): | ||
| return {'type': 'integer', 'value': str(value)} | ||
| elif isinstance(value, long): | ||
| elif isinstance(value, int): |
There was a problem hiding this comment.
Looks like this is a duplicate elif block with python2 long changed to int for python3.
Update tests/decoding_test.py to use the format used by the current
version of toml-test. I also removed Python 2 support (my distro doesn't
ship it, so I can't test it).
Also add tests/encoding_test.py for encoder tests
Still quite a few failures, mostly because it looks like it hasn't been
updated to use 1.0 yet:
% toml-test ./decoding_test.py | tail -n2
valid tests: 139 passed, 18 failed
invalid tests: 230 passed, 53 failed
% toml-test ./encoding_test.py -encoder | tail -n1
encoder tests: 146 passed, 11 failed
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests/decoding_test.py to use the format used by the current version of toml-test. I also removed Python 2 support (my distro doesn't ship it, so I can't test it).
Also add tests/encoding_test.py for encoder tests
Still quite a few failures, mostly because it looks like it hasn't been updated to use 1.0 yet: