Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout component 4.x #845

Merged
merged 83 commits into from
Mar 3, 2023
Merged

Callout component 4.x #845

merged 83 commits into from
Mar 3, 2023

Conversation

bspeare
Copy link
Contributor

@bspeare bspeare commented Jan 6, 2023

Resolves #844

@GaryRidgway GaryRidgway self-assigned this Jan 17, 2023
@GaryRidgway
Copy link
Contributor

I had a neat idea to try and make a function to parse our column classes to output labels, but the @pyrello on my shoulder told me it may have been too much. I have enshrined it in this compare statement so we can look at what it would do if we ever wanted to use it in the future!

@GaryRidgway
Copy link
Contributor

On first glance, the videos really don't want to grow in height...

@GaryRidgway
Copy link
Contributor

GaryRidgway commented Feb 17, 2023

Seems like we need to adjust to allow remote videos and whatnot not be mapped. Blargh.

Not sure what keeps happening, but I am obviously having a hard time keeping everything in this PR straight, lol. Don't think this is an issue.

@GaryRidgway GaryRidgway marked this pull request as ready for review February 22, 2023 21:12
@GaryRidgway GaryRidgway requested a review from a team February 22, 2023 21:12
@GaryRidgway GaryRidgway removed their assignment Feb 22, 2023
@GaryRidgway GaryRidgway marked this pull request as draft February 23, 2023 18:41
@GaryRidgway GaryRidgway marked this pull request as ready for review March 3, 2023 16:31
Copy link
Contributor

@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@pyrello pyrello merged commit 591715d into 4.x Mar 3, 2023
@pyrello pyrello deleted the callout_component_4_x branch March 3, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x - Create callout component
3 participants