Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brand bar and logo components, clean-up #694

Merged
merged 14 commits into from
May 25, 2022
Merged

Add brand bar and logo components, clean-up #694

merged 14 commits into from
May 25, 2022

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented May 20, 2022

Resolves #691
Resolves #692

To test

@pyrello pyrello changed the base branch from 3.x to 4.x May 20, 2022 21:08
@pyrello pyrello added the 4.x 4.x version label May 20, 2022
@pyrello pyrello changed the title Add IOWA bar and logo components Add header and logo components May 24, 2022
@pyrello pyrello changed the title Add header and logo components Add brand bar and logo components May 24, 2022
…xample content. Reorganizing the other components into component folders.
@pyrello pyrello changed the title Add brand bar and logo components Add brand bar and logo components, clean-up May 24, 2022
…ded test workflow for GH actions to see if it works.
@pyrello pyrello marked this pull request as ready for review May 24, 2022 20:50
@pyrello pyrello requested a review from a team May 24, 2022 20:50
@pyrello pyrello marked this pull request as draft May 24, 2022 20:54
@pyrello pyrello marked this pull request as ready for review May 24, 2022 20:58
@pyrello pyrello marked this pull request as draft May 24, 2022 20:58
@pyrello pyrello marked this pull request as ready for review May 24, 2022 20:59
@bspeare
Copy link
Contributor

bspeare commented May 24, 2022

Are the default slots supposed to be styled?
Screen Shot 2022-05-24 at 4 01 48 PM

@pyrello
Copy link
Contributor Author

pyrello commented May 24, 2022

I’m trying out changing the conditions under which GH actions builds the docs. Going forward (for PRs based on the 4.x branch) the workflow to build the docs should only run if the PR is ready for review. This means that you can push to your hearts content without incurring that overhead, but if you want to actually build the docs, you need to mark the PR as ready for review, at least temporarily. Marking it as ready for review should immediately trigger that task.

@pyrello
Copy link
Contributor Author

pyrello commented May 25, 2022

Are the default slots supposed to be styled?

Related: #695

@GaryRidgway
Copy link
Contributor

I will be taking a look at this soon!

@GaryRidgway GaryRidgway self-assigned this May 25, 2022
@GaryRidgway
Copy link
Contributor

Based on test instructions and that there were no glaring issues, I think this is good!

Copy link
Contributor

@GaryRidgway GaryRidgway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@GaryRidgway GaryRidgway removed their assignment May 25, 2022
@pyrello pyrello merged commit dc8ac1b into 4.x May 25, 2022
@pyrello pyrello deleted the iowa_bar branch May 25, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exportable IOWA bar component
3 participants