💥 Add strong types for JSON.parse and JSON.stringify

[aaditmshah]

No description provided.

[uhyo]

Thank you, exciting work 🥰
Allow me to take some time understanding this.

[aaditmshah]

Here is some documentation that explains the changes I made in detail.

• 💥 Add strong typing for JSON.parse when reviver is specified mattpocock/ts-reset#123
• ✨ Add strong typing for JSON.stringify mattpocock/ts-reset#124

Let me know if you have any additional questions.

[graphemecluster]

I regret to tell that the repo you mentioned is the biggest rival which upsets the author of this repo. There must be something missing that could further improve this repo such that there are more stargazers.

[uhyo]

It's not that serious 😅 (I still think mine better resets type definitions than theirs though!)

I think I can take time for review on this weekend. Thanks for additional explanation!

[uhyo]

Got it! Thank you 🙌

[aaditmshah]

I regret to tell that the repo you mentioned is the biggest rival which upsets the author of this repo.

I completely understand.

There must be something missing that could further improve this repo such that there are more stargazers.

I believe adding more comprehensive documentation, creating video tutorials and screencasts, and advertising via word of mouth should increase the popularity of this library significantly.

It's not that serious 😅 (I still think mine better resets type definitions than theirs though!)

Oh, yes. 100%. Using @typescript/xxx packages is the right way to reset the type definitions. It actually replaces the incorrect types instead of simply adding alternative type definitions, which from my personal experience is problematic as you can still use the incorrect type definitions.

I think I can take time for review on this weekend. Thanks for additional explanation!

Thank you for approving and merging my changes so quickly. Let me know if there's any other way I can help make this library better.

Also, pardon my forthrightness but when will the next version of this library with my changes be released?

[uhyo]

I have to upgrade to TypeScript 5.0 before release the next version. I'll take time tomorrow 🙂