Skip to content

Commit

Permalink
feat: Upgrade TypeScript version to 5.3
Browse files Browse the repository at this point in the history
Merge branch 'ts-5.3'
  • Loading branch information
uhyo committed Dec 26, 2023
2 parents a674a56 + 12acec0 commit 8b47679
Show file tree
Hide file tree
Showing 21 changed files with 311 additions and 2,594 deletions.
13 changes: 12 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,15 @@ Follow below steps to run tests locally.
2. `npm run build:lib`
3. `npm run build:package`
4. `npm run install` in tests directory
5. `npm test` in tests directory
5. `npm test` in tests directory

## Upgrading TypeScript version

Below is the procedure to upgrade TypeScript version.

1. Update `typescript` dependency in `package.json` and `tests/package.json`
2. Update the git submodule in `TypeScript` directory (use the git tag of target version)
3. Build this library (see 'Commiting Build Artifacts' section)
4. Review the diff in `generated/lib.*.d.ts` files. This represents the diff of TypeScript library between the previous version and the target version. If any change is undesirable (e.g. contains a new `any`), implement a fix in `lib/` directory (maybe as a separate task).
5. Run tests with the new version, of course.
6. Done!
2 changes: 1 addition & 1 deletion TypeScript
Submodule TypeScript updated 4539 files
14 changes: 7 additions & 7 deletions docs/diff/dom.generated.d.ts.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Index: dom.generated.d.ts
===================================================================
--- dom.generated.d.ts
+++ dom.generated.d.ts
@@ -2941,11 +2941,16 @@
@@ -2943,11 +2943,16 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AudioParamMap) */
Expand All @@ -25,7 +25,7 @@ Index: dom.generated.d.ts
}

declare var AudioParamMap: {
@@ -3362,9 +3367,9 @@
@@ -3364,9 +3369,9 @@
blob(): Promise<Blob>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Request/formData) */
formData(): Promise<FormData>;
Expand All @@ -36,7 +36,7 @@ Index: dom.generated.d.ts
text(): Promise<string>;
}

@@ -8826,11 +8831,11 @@
@@ -8828,11 +8833,11 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/EventCounts) */
Expand All @@ -51,7 +51,7 @@ Index: dom.generated.d.ts
}

declare var EventCounts: {
@@ -9372,11 +9377,16 @@
@@ -9374,11 +9379,16 @@
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/FontFaceSet/check) */
check(font: string, text?: string): boolean;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/FontFaceSet/load) */
Expand All @@ -71,7 +71,7 @@ Index: dom.generated.d.ts
addEventListener<K extends keyof FontFaceSetEventMap>(
type: K,
listener: (this: FontFaceSet, ev: FontFaceSetEventMap[K]) => any,
@@ -17018,11 +17028,16 @@
@@ -17020,11 +17030,16 @@
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/MIDIInputMap)
*/
Expand All @@ -91,7 +91,7 @@ Index: dom.generated.d.ts
}

declare var MIDIInputMap: {
@@ -17085,11 +17100,16 @@
@@ -17087,11 +17102,16 @@
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/MIDIOutputMap)
*/
Expand All @@ -111,7 +111,7 @@ Index: dom.generated.d.ts
}

declare var MIDIOutputMap: {
@@ -21370,11 +21390,11 @@
@@ -21372,11 +21392,11 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCStatsReport) */
Expand Down
Loading

0 comments on commit 8b47679

Please sign in to comment.