Remove eclipse-collections dependency #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhafner
approved these changes
Nov 17, 2022
Which absolutely makes sense if it makes something substantially better or easier. But in this case, all it seemed to do was save one call to FWIW Additionally, perhaps consider making this an API plugin. JFrog aren't happy with our bandwidth use, and bundling 11MB in a dozen different plugins probably contributes some to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested except for autotests.
Fixes #225. The minimal convenience doesn't seem worth the giant dependency it pulls in. Perhaps I'm missing something here, but even so, there's probably a reasonable JDK type to take care of it, instead of Eclipse Collections.