Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relative test success impact in test configurations #386

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Add relative test success impact in test configurations #386

merged 2 commits into from
Oct 16, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Oct 11, 2024

For each configuration, a validation method has been added to ensure that only valid configurations are specified.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Oct 11, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (6e36331) to head (27ce8f2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/edu/hm/hafner/grading/Configuration.java 66.66% 3 Missing ⚠️
...a/edu/hm/hafner/grading/AnalysisConfiguration.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #386      +/-   ##
============================================
+ Coverage     84.10%   85.12%   +1.01%     
- Complexity      390      429      +39     
============================================
  Files            26       26              
  Lines          1208     1230      +22     
  Branches         70       73       +3     
============================================
+ Hits           1016     1047      +31     
+ Misses          158      153       -5     
+ Partials         34       30       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 141 passed)
   〰️   Line Coverage: 87% (154 missed lines)
   ➰   Branch Coverage: 80% (67 missed branches)
   PIT   Mutation Coverage: 77% (163 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: 4 warnings (high: 1, normal: 2, low: 1)
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)

Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 143 passed)
   〰️   Line Coverage: 88% (154 missed lines)
   ➰   Branch Coverage: 81% (66 missed branches)
   PIT   Mutation Coverage: 77% (162 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: 4 warnings (high: 1, normal: 2, low: 1)
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)

Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

@uhafner uhafner linked an issue Oct 14, 2024 that may be closed by this pull request
Use success or failure rate of tests as score impact #385
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2024
View reviewed changes
src/test/java/edu/hm/hafner/grading/TestConfigurationTest.java
@ParameterizedTest(name = "{index} => Positive configuration: {1}")
@MethodSource
@DisplayName("should identify positive configurations")
void shouldIdentifyPositiveValues(final String json, @SuppressWarnings("unused") final String displayName) {

Check notice

Code scanning / CodeQL

Useless parameter Note test

The parameter 'displayName' is never used.
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 149 passed)
   〰️   Line Coverage: 88% (154 missed lines)
   ➰   Branch Coverage: 81% (64 missed branches)
   PIT   Mutation Coverage: 77% (162 survived mutations)
   CheckStyle   CheckStyle: 1 warning (normal: 1)
   PMD   PMD: 4 warnings (high: 1, normal: 2, low: 1)
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)

Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
src/test/java/edu/hm/hafner/grading/AnalysisConfigurationTest.java
@ParameterizedTest(name = "{index} => Positive configuration: {1}")
@MethodSource
@DisplayName("should identify positive configurations")
void shouldIdentifyPositiveValues(final String json, @SuppressWarnings("unused") final String displayName) {

Check notice

Code scanning / CodeQL

Useless parameter Note test

The parameter 'displayName' is never used.
src/test/java/edu/hm/hafner/grading/CoverageConfigurationTest.java
@ParameterizedTest(name = "{index} => Positive configuration: {1}")
@MethodSource
@DisplayName("should identify positive configurations")
void shouldIdentifyPositiveValues(final String json, @SuppressWarnings("unused") final String displayName) {

Check notice

Code scanning / CodeQL

Useless parameter Note test

The parameter 'displayName' is never used.
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 155 passed)
   〰️   Line Coverage: 88% (153 missed lines)
   ➰   Branch Coverage: 83% (57 missed branches)
   PIT   Mutation Coverage: 77% (161 survived mutations)
   CheckStyle   CheckStyle: 2 warnings (normal: 2)
   PMD   PMD: 4 warnings (high: 1, normal: 2, low: 1)
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)

Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

@uhafner
Add relative test success impact in test score and config.
36934cd 
Test success or failure rate will determine the impact.

For each configuration, a validation method has been added to
ensure that only valid configurations are specified.
@uhafner
Improve coverage of positive impacts.
27ce8f2
@github-actions GitHub Actions
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 155 passed)
   〰️   Line Coverage: 88% (153 missed lines)
   ➰   Branch Coverage: 83% (57 missed branches)
   PIT   Mutation Coverage: 77% (161 survived mutations)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: 4 warnings (high: 1, normal: 2, low: 1)
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)

Created by Quality Monitor v1.11.0 (#99404b7). More details are shown in the GitHub Checks Result.

@uhafner uhafner marked this pull request as ready for review October 15, 2024 12:29
@uhafner uhafner merged commit 7ec4617 into main Oct 16, 2024
16 checks passed
@uhafner uhafner deleted the test-percentage branch October 16, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use success or failure rate of tests as score impact
1 participant
@uhafner