Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move comments creation to the model #288

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Move comments creation to the model #288

merged 4 commits into from
Dec 12, 2023

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Dec 12, 2023

Comments for static analysis warnings, for lines with missing coverage, and for lines with survived mutations can be rendered in GitHub and GitLab using different APIs. The base class that creates the comments is now part of the model while the implementations that use the vendor specific API are placed in the corresponding actions.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Dec 12, 2023
Copy link

🎓 Quality Checks - 328 of 400

🚦 JUnit - 100 of 100

71 tests passed

🐾 JaCoCo - 76 of 100

76% Covered , 24% Missed

🦠 PIT - 72 of 100

72% Killed , 28% Survived

⚠️ Warnings - 80 of 100

20 warnings found (0 errors, 0 high, 12 normal, 8 low)

More details are available in the GitHub Checks Result.

src/main/java/edu/hm/hafner/grading/CommentBuilder.java Dismissed Show dismissed Hide dismissed
src/main/java/edu/hm/hafner/grading/CommentBuilder.java Dismissed Show dismissed Hide dismissed
src/main/java/edu/hm/hafner/grading/CommentBuilder.java Dismissed Show dismissed Hide dismissed
Copy link

🎓 Quality Checks - 327 of 400

🚦 JUnit - 100 of 100

71 tests passed

🐾 JaCoCo - 75 of 100

75% Covered , 25% Missed

🦠 PIT - 72 of 100

72% Killed , 28% Survived

⚠️ Warnings - 80 of 100

20 warnings found (0 errors, 0 high, 12 normal, 8 low)

More details are available in the GitHub Checks Result.

Copy link

🎓 Quality Checks - 330 of 400

🚦 JUnit - 100 of 100

71 tests passed

🐾 JaCoCo - 75 of 100

75% Covered , 25% Missed

🦠 PIT - 72 of 100

72% Killed , 28% Survived

⚠️ Warnings - 83 of 100

17 warnings found (0 errors, 0 high, 10 normal, 7 low)

More details are available in the GitHub Checks Result.

Copy link

🎓 Quality Checks - 339 of 400

🚦 JUnit - 100 of 100

71 tests passed

🐾 JaCoCo - 75 of 100

75% Covered , 25% Missed

🦠 PIT - 72 of 100

72% Killed , 28% Survived

⚠️ Warnings - 92 of 100

8 warnings found (0 errors, 0 high, 6 normal, 2 low)

More details are available in the GitHub Checks Result.

@uhafner uhafner merged commit e431b19 into main Dec 12, 2023
13 checks passed
@uhafner uhafner deleted the comments branch December 12, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant