Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite model to use analysis-model and coverage-model #271

Merged
merged 13 commits into from
Nov 21, 2023
Merged

Rewrite model to use analysis-model and coverage-model #271

merged 13 commits into from
Nov 21, 2023

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Nov 6, 2023

Total rewrite using the new models.

@uhafner uhafner added the breaking Breaking Changes label Nov 6, 2023
This was linked to issues Nov 6, 2023
Add coverage options #62
Closed
Make static analysis parsers configurable #78
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2023
View reviewed changes
src/main/java/edu/hm/hafner/grading/GradingReport.java Fixed Show fixed Hide fixed
src/main/java/edu/hm/hafner/grading/AggregatedScore.java
*
* @return the created report
*/
Report create(ToolConfiguration tool, FilteredLog log);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'log' is never used.
src/main/java/edu/hm/hafner/grading/AggregatedScore.java Fixed Show fixed Hide fixed
src/main/java/edu/hm/hafner/grading/AggregatedScore.java
*
* @return the created report
*/
Node create(ToolConfiguration tool, FilteredLog log);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'log' is never used.
src/main/java/edu/hm/hafner/grading/AggregatedScore.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2023
View reviewed changes
src/main/java/edu/hm/hafner/grading/GradingReport.java
* JUnit reports that many contain details about failed tests
* @return Markdown text
*/
public String getDetails(final AggregatedScore score, final List<Report> testReports) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'testReports' is never used.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2023
View reviewed changes
src/main/java/edu/hm/hafner/grading/AggregatedScore.java
* @return the created report
* @throws NoSuchElementException if there is no test report for the specified tool
*/
Node create(ToolConfiguration tool, FilteredLog log);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'log' is never used.
@uhafner uhafner marked this pull request as ready for review November 21, 2023 11:04
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (84f47ff) 93.36% compared to head (5888654) 87.16%.
Report is 4 commits behind head on main.

Files Patch % Lines
...in/java/edu/hm/hafner/grading/AggregatedScore.java 84.82% 18 Missing and 4 partials ⚠️
...main/java/edu/hm/hafner/grading/Configuration.java 82.85% 1 Missing and 5 partials ⚠️
.../java/edu/hm/hafner/grading/ToolConfiguration.java 85.29% 1 Missing and 4 partials ⚠️
src/main/java/edu/hm/hafner/grading/Score.java 85.18% 2 Missing and 2 partials ⚠️
...main/java/edu/hm/hafner/grading/CoverageScore.java 91.42% 1 Missing and 2 partials ⚠️
...main/java/edu/hm/hafner/grading/JacksonFacade.java 70.00% 3 Missing ⚠️
...a/edu/hm/hafner/grading/CoverageConfiguration.java 85.71% 1 Missing and 1 partial ⚠️
...n/java/edu/hm/hafner/grading/CoverageMarkdown.java 92.30% 2 Missing ⚠️
.../main/java/edu/hm/hafner/grading/TestMarkdown.java 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     93.36%   87.16%   -6.21%     
- Complexity      198      253      +55     
============================================
  Files            23       18       -5     
  Lines           603      670      +67     
  Branches         24       71      +47     
============================================
+ Hits            563      584      +21     
- Misses           34       57      +23     
- Partials          6       29      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 3ffe548 into main Nov 21, 2023
15 of 17 checks passed
@uhafner uhafner deleted the coverage-model branch November 21, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Breaking Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make static analysis parsers configurable Add coverage options
1 participant
@uhafner