Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CICE; add CMEPS fix for GNU and turn on cpld test for GNU; update 35d scripts from P7a mini-release #610

Merged
merged 56 commits into from
Jun 4, 2021

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Jun 1, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  • Updates CICE in ufs-weather. Details of the changes can be found in the associated CICE PR #26 and Icepack PR #4

  • Updates the ice_in_template for changes due to the time manager update. This removes istep0 and instead sets the year_init, month_init and day_init.

  • Updates ice_in_template used by ufs-weather-model by removing many unused namelists or settings. This will make it easier to update CICE because the frequent namelist changes (e.g. renaming settings) will not need to be propagated to ufs-weather unless we actually make use of those settings.

  • Sets tr_FY (the tracer for First Year ice) to false and removes the associated frz_onset and melt_onset variables from the history files. These are diagnostic fields which only make sense for multi-year climate runs. They are reset at July 1 a d Jan 1 of each year and therefore have no real meaning in either the Regression testing or the 35-day long runs done for the S2S prototypes.

  • Makes fix for unitialized AccumCnts in CMEPS and turn on coupled GNU tests in rt_gnu.conf

  • Update 35d scripts from P7a

Issue(s) addressed

  • fixes CICE issue #27
  • fixes CMEPS issue #48

Testing

Testing on Gaea.intel shows that this PR changes baselines solely because the time-manager update results in the frz_onset restart field to be initialized at 999. Previously, the frz_onset field would be initialized as the starting julian day. This field is not required for B4B restarts. All other files compared are B4B with current baselines. Removing the frz_onset variable causes the comparison to fail.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

  • CICE PR #26
  • Icepack PR #4
  • CMEPS PR #49

DeniseWorthen and others added 30 commits March 27, 2021 12:30
This reverts commit 7b826d4.
@BrianCurtis-NOAA
Copy link
Collaborator

Machine: gaea
Compiler: intel
Job: BL
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/659317000/20210603214512/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_24338
Baseline creation and move successful
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/659317000/20210603232418/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_26377
Test regional_quilt_2threads 054 failed in check_result failed
Test regional_quilt_2threads 054 failed in run_test failed
Test regional_control 051 failed in check_result failed
Test regional_control 051 failed in run_test failed
Test regional_quilt 053 failed in check_result failed
Test regional_quilt 053 failed in run_test failed
Test regional_quilt_hafs 055 failed in check_result failed
Test regional_quilt_hafs 055 failed in run_test failed
Test regional_quilt_netcdf_parallel 056 failed in check_result failed
Test regional_quilt_netcdf_parallel 056 failed in run_test failed
Test regional_quilt_RRTMGP 057 failed in check_result failed
Test regional_quilt_RRTMGP 057 failed in run_test failed
Please make changes and add the following label back:
gaea-intel-BL

@DeniseWorthen
Copy link
Collaborator Author

The identical gaea situation happened to me on dell-p3. The baseline looked to create successfully but in fact the 6th compile job failed silently. The baselines report that they were successfully created, but all the jobs which depend on the 6th compile job (COMPILE | APP=ATM SUITES=FV3_GFS_v15_thompson_mynn,FV3_GFS_v15_thompson_mynn_RRTMGP 32BIT=Y) don't run so when the verify step runs, it fails w/ missing baselines for these regional tests. This can have nothing to do w/ auto-bl.

@BrianCurtis-NOAA
Copy link
Collaborator

Machine: orion
Compiler: intel
Job: BL
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/659317000/20210603164509/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_361786
Test cpld_control_c384 006 failed in run_test failed
Test cpld_controlfrac_c384 007 failed in run_test failed
Please make changes and add the following label back:
orion-intel-BL

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jun 4, 2021

Issues:

  1. On Orion, the two failed tests were time-outs during the run.
  2. On Gaea, the attempt to manually compile and re-run the baselines for the Regional tests timed-out in the compile.
  3. On Jet, the jobs never started. I can't even check out my branch, I suspect this is a space issue
    4.0K ./Minsuk.Ji,.
    32K ./Bin.Li
    3.2G ./Brian.Curtis
    2.1G ./Mikyung.Lee
    660M ./Denise.Worthen
    2.0T ./Jun.Wang
    9.9T ./emc.nemspara
    24K ./Dusan.Jovic
    12T .

@DeniseWorthen
Copy link
Collaborator Author

The Orion failure was caused by me not moving the baselines into an INTEL subdirectory.

@BrianCurtis-NOAA
Copy link
Collaborator

Machine: orion
Compiler: intel
Job: RT
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/659317000/20210604074510/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_454393
Test cpld_controlfrac 003 failed in check_result failed
Test cpld_controlfrac 003 failed in run_test failed
Test cpld_control_c384 012 failed in run_test failed
Test cpld_controlfrac_c384 014 failed in run_test failed
Please make changes and add the following label back:
orion-intel-RT

BrianCurtis-NOAA and others added 2 commits June 4, 2021 19:37
* the following tests were re-ran

Test 001 cpld_controlfrac PASS
Test 002 cpld_restartfrac PASS
Test 003 cpld_control_c384 PASS
Test 004 cpld_restart_c384 PASS
Test 005 cpld_controlfrac_c384 PASS
Test 006 cpld_restartfrac_c384 PASS
@DeniseWorthen DeniseWorthen merged commit bebdd6d into ufs-community:develop Jun 4, 2021
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
…community#610)

* Performance optimization of moving nest.

* update atmos_model and FV3GFS_io read performance when io_layout=1,1 and allow one to override data integrity checks in FMS restart logic

* Add the following HAFS ccpp physics suites (@ChunxiZhang-NOAA and @BinLiu-NOAA):
suite_FV3_HAFS_v0_thompson.xml
suite_FV3_HAFS_v0_thompson_nonsst.xml
suite_FV3_HAFS_v0_thompson_noahmp.xml
suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml

* Update submodule UPP to point its latest develop branch as of 05/18/2022.

* Update submodule upp, which has the fix for regional latlon grid crossing the prime meridian.

* Only call atmosphere_fill_nest_cpl at the cap driver time steps (coupling time
steps). This is to reduce the overhead introduced by downscaling the coupling
variables from FV3ATM parent to nest.

* Removed reference to unused variable parent_x.

* FV3-related typedefs changes for the Hurricane PBL options

* Update submodule ccpp/physics, which added the tc_pbl option in the GFS sa-TKE
EDMF PBL scheme for HAFS/hurricane modeling.

* Adding upoff as a namelist parameter

* Update submodule atmos_cubed_sphere, which has updated the time string
in internal tracker output (fort.602, phtcf file).

* Restructure moving nest code from atmos_cubed_sphere into FV3 directory.

* Rename HAFS_v0 CCPP physics suites to HAFS_V1.

* Added namelist flag fv_timers to enable detailed performance timings; defaults to false.

* Removed special CMake handling of moving nest files.  This causes a switch from 'fp-model source' as they were compiled in atmos_cubed_sphere, to 'fp-model consistent' aligned with the FV3atm tree.  Minor rounding differences are noted in forecast results.

* Update submodule ccpp/physics and update tc_pbl standard and long names.

* Removed ifdef MOVING_NEST, as files are included/excluded by cmake

Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov>
Co-authored-by: Rusty.Benson <rusty.benson@noaa.gov>
Co-authored-by: AndrewHazelton <andrew.hazelton@noaa.gov>
Co-authored-by: Biju Thomas <biju.thomas@noaa.gov>
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
1) Fix the bad WE2E test configuration file for MET_verification_only_vx (Issue #608).
2) Make creation of symlinks to pregenerated files depend on whether downstream tasks need those symlinks (Issue #610).
3) Set default value of FIXdir to HOMEdir/fix only when RUN_ENVIR="nco", not when RUN_TASK_MAKE_GRID=False; otherwise, set FIXdir to EXPTDIR (Issue #616).
4) Add a flag to the script get_expts_status.sh so that if an experiment hasn't been launched yet, it calls the launch script launch_FV3LAM_wflow.sh to launch it instead of only outputting a message that it's not yet launched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants