Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WW3 with fb_coupling_fields; add cice fix for zlvs #573

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
cac1930
updates for WW3 UKMO fb_coupling_fields which adds two additional
JessicaMeixner-NOAA May 12, 2021
6c70e94
updated one more parameter to add an extra inputs
JessicaMeixner-NOAA May 13, 2021
41587ed
need new baseline for wave restart which has added variable
JessicaMeixner-NOAA May 13, 2021
bccb10a
Merge remote-tracking branch 'origin/develop' into UKMO/fb_coupling_f…
JessicaMeixner-NOAA May 13, 2021
781a59f
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA May 19, 2021
04a05fe
reverting WW3 branch to point to EMC fork and develop branch
JessicaMeixner-NOAA May 19, 2021
4409eda
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA May 27, 2021
1c7e60c
update WW3 to top of develop
JessicaMeixner-NOAA May 27, 2021
e6ee6a0
Point to updated WW3 that has porting for wcoss2 (thanks to Mark Potts)
JessicaMeixner-NOAA May 27, 2021
e329431
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 1, 2021
8160a79
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 2, 2021
2c4a5e2
update a few input files and delete a space
JessicaMeixner-NOAA Jun 2, 2021
72d2d63
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 3, 2021
2382919
update WW3 to latest develop
JessicaMeixner-NOAA Jun 4, 2021
d7993f9
add restart time for wave model to be FHMAX
JessicaMeixner-NOAA Jun 7, 2021
afd6082
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 7, 2021
6d56e60
make sure WW3 is using latest develop
JessicaMeixner-NOAA Jun 7, 2021
17f5107
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 8, 2021
605a92b
update rt.conf, ww3 does work on cheyenne
JessicaMeixner-NOAA Jun 8, 2021
794e5c4
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 9, 2021
377bfb9
hera.intel log showing everything passes except ww3restart file
JessicaMeixner-NOAA Jun 9, 2021
26ba266
update WW3 to latest
JessicaMeixner-NOAA Jun 9, 2021
ef2fccc
Pointing to Denise's CICE branch
JessicaMeixner-NOAA Jun 10, 2021
0b29f00
Merge remote-tracking branch 'UFS/develop' into UKMO/fb_coupling_fields
JessicaMeixner-NOAA Jun 10, 2021
779cbe0
updating BL_DATE to todays date
JessicaMeixner-NOAA Jun 10, 2021
d2c4941
adding line for CI in PR template
JessicaMeixner-NOAA Jun 10, 2021
af7e58c
wcoss cray logs
JessicaMeixner-NOAA Jun 10, 2021
1a1dc5d
RT JOBS PASSED: hera.gnu. Log file uploaded.
BrianCurtis-NOAA Jun 10, 2021
63628fc
RT JOBS PASSED: hera.intel. Log file uploaded.
BrianCurtis-NOAA Jun 10, 2021
a1f83bf
RT Passed on wcoss_dell_p3
JessicaMeixner-NOAA Jun 10, 2021
35c0fe0
RT JOBS PASSED: gaea.intel. Log file uploaded.
BrianCurtis-NOAA Jun 10, 2021
3d0019c
RT JOBS PASSED: orion.intel. Log file uploaded.
BrianCurtis-NOAA Jun 10, 2021
a599bf4
RT JOBS PASSED: cheyenne.gnu. Log file uploaded.
BrianCurtis-NOAA Jun 10, 2021
9909e42
RT JOBS PASSED: jet.intel. Log file uploaded.
BrianCurtis-NOAA Jun 10, 2021
58622d4
RT JOBS PASSED: cheyenne.intel. Log file uploaded.
BrianCurtis-NOAA Jun 11, 2021
305c9be
reverting CICE submodule
JessicaMeixner-NOAA Jun 11, 2021
8839de4
pointing to correct CICE hash 9d88d92
JessicaMeixner-NOAA Jun 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ How were these changes tested? What compilers / HPCs was it tested with? Are the
- [ ] jet.intel
- [ ] wcoss_cray
- [ ] wcoss_dell_p3
- [ ] CI

## Dependencies

Expand Down
4 changes: 1 addition & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,7 @@ endif()
###############################################################################
if(WW3)
if(CMAKE_Platform)
if(${CMAKE_Platform} STREQUAL "wcoss2")
set(WW3_COMP "wcoss_cray")
elseif(${CMAKE_Platform} MATCHES "linux*" OR ${CMAKE_Platform} MATCHES "macosx*")
if(${CMAKE_Platform} MATCHES "linux*" OR ${CMAKE_Platform} MATCHES "macosx*")
if (CMAKE_Fortran_COMPILER_ID MATCHES "GNU")
set(WW3_COMP "gnu")
elseif (CMAKE_Fortran_COMPILER_ID MATCHES "Intel")
Expand Down
2 changes: 1 addition & 1 deletion WW3
Submodule WW3 updated 320 files
192 changes: 96 additions & 96 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

596 changes: 298 additions & 298 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

570 changes: 285 additions & 285 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

192 changes: 96 additions & 96 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

600 changes: 300 additions & 300 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

560 changes: 280 additions & 280 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

912 changes: 390 additions & 522 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

338 changes: 169 additions & 169 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

713 changes: 447 additions & 266 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ export WINDLINE='$'
export CURRLINE='$'
export NFGRIDS=0
export NMGRIDS=1
export ww3gline="'glo_30m' 'no' 'no' 'CPL:native' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'glo_30m' 'no' 'no' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"

# Regional
export WRITE_RESTART_WITH_BCS=.false.
Expand Down Expand Up @@ -741,7 +741,7 @@ export KTHERM=1
export TFREEZE_OPTION='linear_salt'

#wave
export ww3gline="'glo_1deg' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'glo_1deg' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export WW3OUTPUTTYPE=' 1'

# checkpoint restarts
Expand Down
1 change: 0 additions & 1 deletion tests/rt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,5 @@ RUN | datm_cdeps_debug_cfsr
# ATM-WAV tests #
###################################################################################################################################################################################

# WW3 not working on Cheyenne in the past, need to check if it works now
COMPILE | APP=ATMW SUITES=FV3_GFS_v16 | - wcoss_cray | fv3 |
RUN | control_atmwav | - wcoss_cray | fv3 |
2 changes: 1 addition & 1 deletion tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ if [[ $TESTS_FILE =~ '35d' ]]; then
TEST_35D=true
fi

BL_DATE=20210609
BL_DATE=20210610
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down
3 changes: 2 additions & 1 deletion tests/tests/cpld_bmark_wave_v16
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ export MOM6_REPRO_LA='True'

export RUNID="cpcice"

export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export WW3RSTDTHR=${FHMAX}

export INPUT_NML=input.benchmark_v16.nml.IN

Expand Down
3 changes: 2 additions & 1 deletion tests/tests/cpld_bmark_wave_v16_35d
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ export MOM6_REPRO_LA='True'

export RUNID="cpcice"

export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export WW3RSTDTHR=${FHMAX}

export INPUT_NML=input.benchmark_v16.nml.IN

Expand Down
3 changes: 2 additions & 1 deletion tests/tests/cpld_bmark_wave_v16_noahmp
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ export MOM6_REPRO_LA='True'

export RUNID="cpcice"

export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export WW3RSTDTHR=${FHMAX}

export INPUT_NML=input.benchmark_v16.nml.IN

Expand Down
3 changes: 2 additions & 1 deletion tests/tests/cpld_bmark_wave_v16_noahmp_35d
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ export MOM6_REPRO_LA='True'

export RUNID="cpcice"

export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export WW3RSTDTHR=${FHMAX}

export INPUT_NML=input.benchmark_v16.nml.IN

Expand Down
3 changes: 2 additions & 1 deletion tests/tests/cpld_bmark_wave_v16_noahmp_nsst
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ export MOM6_REPRO_LA='True'

export RUNID="cpcice"

export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export ww3gline="'gwes_30m' 'no' 'CPL:native' 'CPL:native' 'CPL:native' 'no' 'no' 'no' 'no' 'no' 1 1 0.00 1.00 F"
export WW3RSTDTHR=${FHMAX}

export INPUT_NML=input.benchmark_v16.nml.IN

Expand Down