Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) #2389

Merged
merged 71 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
6b980d2
Initial commit
DavidNew-NOAA May 30, 2024
0449407
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jun 3, 2024
e09b851
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jun 17, 2024
c3be4de
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jun 20, 2024
83f696e
Merge remote-tracking branch 'origin/develop' into feature/cubed_sphe…
DavidNew-NOAA Jul 1, 2024
1f72150
UPdate hashes
DavidNew-NOAA Jul 1, 2024
bf2a31b
Update hashes
DavidNew-NOAA Jul 1, 2024
44bbc02
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jul 15, 2024
34d1087
Update FV3 hash
DavidNew-NOAA Jul 18, 2024
24cb269
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jul 18, 2024
040f4c5
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jul 18, 2024
4830205
Specify the squeue format explicitly
DusanJovic-NOAA Jul 26, 2024
fb56194
Add ${ECF_TRYNO} suffix to compile and run log files, if ecflow is used
DusanJovic-NOAA Jul 26, 2024
47e9560
Check the job exit status in rt_utils.sh
DusanJovic-NOAA Jul 29, 2024
fbd9014
Fix shellcheck warnings
DusanJovic-NOAA Jul 29, 2024
306387a
Fix shellcheck warnings
DusanJovic-NOAA Jul 29, 2024
3b496f4
Add ecflow_client label update
DusanJovic-NOAA Jul 29, 2024
f93e983
Support COMPLETING Slurm job status
DusanJovic-NOAA Jul 29, 2024
0edee86
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Jul 30, 2024
8d1cebc
Merge remote-tracking branch 'origin/develop' into rt_squeue_state
DusanJovic-NOAA Aug 1, 2024
9690557
Move code from check_results function into run_test.sh
DusanJovic-NOAA Aug 2, 2024
107001d
Fix shellcheck warning
DusanJovic-NOAA Aug 2, 2024
72a38d3
Add timout test
DusanJovic-NOAA Aug 3, 2024
5a0de70
Fix shellcheck warning
DusanJovic-NOAA Aug 5, 2024
db70a38
Merge remote-tracking branch 'origin/develop' into rt_squeue_state
DusanJovic-NOAA Aug 5, 2024
f00db23
CDEPS fork in .gitmodules
NickSzapiro-NOAA Aug 6, 2024
05164c5
Merge remote-tracking branch 'origin/develop' into rt_squeue_state
DusanJovic-NOAA Aug 6, 2024
3ff2c92
Remove setting ecflow labels from submit_and_wait. Let's not complica…
DusanJovic-NOAA Aug 6, 2024
4eff4f1
For gfs and cfsr datm datamodes, use gefs. b4b
NickSzapiro-NOAA Aug 6, 2024
a0bd6a1
Shelcheck warning fix
DusanJovic-NOAA Aug 6, 2024
6e7948f
Rename CDEPS-related FILENAME_BASE to FILEBASE_DATM (without .) to avoid
NickSzapiro-NOAA Aug 6, 2024
7688f67
Merge branch 'ufs-community:develop' into feature/cubed_sphere_inc
DavidNew-NOAA Aug 8, 2024
de1c02e
Update FV3 hash
DavidNew-NOAA Aug 8, 2024
403369a
Set .gitmodules
DavidNew-NOAA Aug 8, 2024
e2a55e3
add increment_file_on_native_grid to test namelists
DavidNew-NOAA Aug 9, 2024
01582b4
Update FV3 hash
DavidNew-NOAA Aug 9, 2024
2988735
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Aug 9, 2024
1156400
Update hash
DavidNew-NOAA Aug 9, 2024
699ead8
Merge branch 'develop' into feature/cubed_sphere_inc
DavidNew-NOAA Aug 13, 2024
3d220fb
Merge remote-tracking branch 'origin/develop' into rt_squeue_state
DusanJovic-NOAA Aug 13, 2024
a0ca819
Use realpath instead of readlink in build.sh and tests/compile.sh
DusanJovic-NOAA Aug 13, 2024
219feff
Merge branch 'ufs-community:develop' into simplify_datm
NickSzapiro-NOAA Aug 13, 2024
fd61b6c
Update CDEPS hash
NickSzapiro-NOAA Aug 13, 2024
4000d72
Remove gfs_hafs from CDEPS-interface/cdeps_files.cmake
NickSzapiro-NOAA Aug 13, 2024
d244707
Tests pass b4b on hercules
NickSzapiro-NOAA Aug 13, 2024
35ce742
Fix typo in .gitmodules
DavidNew-NOAA Aug 14, 2024
1efc97f
Update hash
DavidNew-NOAA Aug 15, 2024
84ab299
Update run_test.sh. Call write_fail_test if test files in check_results
DusanJovic-NOAA Aug 19, 2024
37b0d74
Merge remote-tracking branch 'origin/develop' into rt_squeue_state
DusanJovic-NOAA Aug 20, 2024
d38f4f5
Merge remote-tracking branch 'origin/develop' into rt_squeue_state
DusanJovic-NOAA Aug 21, 2024
212fc7d
Merge branch 'develop' into simplify_datm
NickSzapiro-NOAA Aug 21, 2024
d8f07f6
Remove commented atm_datamode from default_vars.sh
NickSzapiro-NOAA Aug 21, 2024
0e49a81
Merge DavidNew-NOAA/feature/cubed_sphere_inc
NickSzapiro-NOAA Aug 21, 2024
87535af
Merge DusanJovic-NOAA/rt_squeue_state
NickSzapiro-NOAA Aug 21, 2024
20baca2
Tests pass b4b on hera
NickSzapiro-NOAA Aug 21, 2024
49a2dca
Merge branch ufs-community/develop into simplify_datm
NickSzapiro-NOAA Aug 23, 2024
af678c6
[AutoRT] Hercules Job Failed!
epic-cicd-jenkins Aug 26, 2024
7245949
[AutoRT] Derecho Job Completed.
epic-cicd-jenkins Aug 26, 2024
7a3782c
sync up fv3 branch
jkbk2004 Aug 26, 2024
0890fac
Acorn RT Log: Passed
BrianCurtis-NOAA Aug 26, 2024
bd7669c
WCOSS2 RT Log: Passed
BrianCurtis-NOAA Aug 26, 2024
c369d42
add orion RT logs: passed
zach1221 Aug 26, 2024
ed8d576
add hercules RT logs: passed
zach1221 Aug 26, 2024
5b23eba
[AutoRT] Gaea Job Completed.
epic-cicd-jenkins Aug 26, 2024
ae1cde1
add derecho RT logs: passed
zach1221 Aug 26, 2024
f1bcc82
Delete RT-run-Hercules.log
zach1221 Aug 26, 2024
f76921e
Update Jenkinsfile.combined remove failed test log push
zach1221 Aug 26, 2024
35d85c0
[AutoRT] Hera Job Completed.
epic-cicd-jenkins Aug 26, 2024
b37637c
add jet RT log passed
FernandoAndrade-NOAA Aug 26, 2024
7612dc6
ORT Jobs Completed.
epic-cicd-jenkins Aug 26, 2024
783e1f3
Update .gitmodules, hashes for CDEPS & FV3
NickSzapiro-NOAA Aug 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
branch = emc/develop
[submodule "CDEPS"]
path = CDEPS-interface/CDEPS
url = https://github.com/NOAA-EMC/CDEPS
branch = develop
url = https://github.com/NickSzapiro-NOAA/CDEPS
branch = simplify_datm
[submodule "GOCART"]
path = GOCART
url = https://github.com/GEOS-ESM/GOCART
Expand Down
3 changes: 0 additions & 3 deletions CDEPS-interface/cdeps_files.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,11 @@ list(APPEND cdeps_dshr_files

list(APPEND cdeps_datm_files
CDEPS/datm/atm_comp_nuopc.F90
CDEPS/datm/datm_datamode_cfsr_mod.F90
CDEPS/datm/datm_datamode_clmncep_mod.F90
CDEPS/datm/datm_datamode_core2_mod.F90
CDEPS/datm/datm_datamode_cplhist_mod.F90
CDEPS/datm/datm_datamode_era5_mod.F90
CDEPS/datm/datm_datamode_gefs_mod.F90
CDEPS/datm/datm_datamode_gfs_mod.F90
CDEPS/datm/datm_datamode_gfs_hafs_mod.F90
CDEPS/datm/datm_datamode_jra_mod.F90
CDEPS/datm/datm_datamode_simple_mod.F90
)
Expand Down
8 changes: 4 additions & 4 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1328,10 +1328,10 @@ export_datm_cdeps ()
export INPUT_NML=input.mom6.nml.IN
export DIAG_TABLE=diag_table_template
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export atm_datamode=${DATM_SRC}
export stream_files=INPUT/${FILENAME_BASE}201110.nc
export FILEBASE_DATM=cfsr
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export atm_datamode=GEFS
export stream_files=INPUT/${FILEBASE_DATM}.201110.nc
export EXPORT_ALL=.false.
export STREAM_OFFSET=0

Expand Down
735 changes: 368 additions & 367 deletions tests/logs/RegressionTests_hercules.log

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/parm/datm.streams.IN
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
stream_info: @[FILENAME_BASE]01
stream_info: @[FILEBASE_DATM].01
taxmode01: limit
mapalgo01: bilinear
tInterpAlgo01: linear
Expand Down
1 change: 0 additions & 1 deletion tests/test_changes.list
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
cpld_control_sfs intel
4 changes: 2 additions & 2 deletions tests/tests/datm_cdeps_3072x1536_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ export LIST_FILES="RESTART/20111002.000000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR3072x1536
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export WLCLK=15
export IATM=3072
export JATM=1536
export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export MESH_ATM=gfs_mesh.nc
export atm_datamode=GFS
export atm_datamode=GEFS
export RESTART_N=12
export stream_files="INPUT/cfsr.2011100100_3072x1536.nc INPUT/cfsr.2011100106_3072x1536.nc INPUT/cfsr.2011100112_3072x1536.nc INPUT/cfsr.2011100118_3072x1536.nc INPUT/cfsr.2011100200_3072x1536.nc INPUT/cfsr.2011100206_3072x1536.nc"
export eps_imesh=2.5e-1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_bulk_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20111002.000000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export RESTART_N=12
Expand Down
6 changes: 3 additions & 3 deletions tests/tests/datm_cdeps_bulk_gefs
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export DATM_SRC=GEFS_NEW
export FILENAME_BASE=gefs.
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export stream_files="INPUT/${FILENAME_BASE}201110.nc"
export FILEBASE_DATM=gefs
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export stream_files="INPUT/${FILEBASE_DATM}.201110.nc"
export STREAM_OFFSET=-21600

export RESTART_N=12
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_ciceC_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20111002.000000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export RESTART_N=12
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_control_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20111002.000000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export RESTART_N=12
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_control_cfsr_faster
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20111002.000000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export RESTART_N=12
Expand Down
6 changes: 3 additions & 3 deletions tests/tests/datm_cdeps_control_gefs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export DATM_SRC=GEFS_NEW
export FILENAME_BASE=gefs.
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export stream_files="INPUT/${FILENAME_BASE}201110.nc"
export FILEBASE_DATM=gefs
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export stream_files="INPUT/${FILEBASE_DATM}.201110.nc"
export STREAM_OFFSET=-21600
export RESTART_N=12
export eps_imesh=2.5e-1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_debug_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20111001.060000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export DAYS=0.25
Expand Down
6 changes: 3 additions & 3 deletions tests/tests/datm_cdeps_gfs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20210323.060000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=GFS
export FILENAME_BASE=gfs.
export FILEBASE_DATM=gfs
export SYEAR=2021
export SMONTH=03
export SDAY=22
Expand All @@ -23,8 +23,8 @@ export JATM=1536
export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export atm_datamode=GFS
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export atm_datamode=GEFS
export CICE_KTHERM=2
export CICE_TFREEZE_OPTION=mushy
export RESTART_N=12
Expand Down
6 changes: 3 additions & 3 deletions tests/tests/datm_cdeps_iau_gefs
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export DATM_SRC=GEFS_NEW
export FILENAME_BASE=gefs.
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export stream_files="INPUT/${FILENAME_BASE}201110.nc"
export FILEBASE_DATM=gefs
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export stream_files="INPUT/${FILEBASE_DATM}.201110.nc"
export STREAM_OFFSET=-21600
export RESTART_N=12
export eps_imesh=2.5e-1
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_multiple_files_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export LIST_FILES="RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc"

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export RESTART_N=12
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_mx025_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export LIST_FILES="RESTART/20111001.120000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export DAYS=0.5
Expand Down
6 changes: 3 additions & 3 deletions tests/tests/datm_cdeps_mx025_gefs
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export DATM_SRC=GEFS_NEW
export FILENAME_BASE=gefs.
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export stream_files="INPUT/${FILENAME_BASE}201110.nc"
export FILEBASE_DATM=gefs
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export stream_files="INPUT/${FILEBASE_DATM}.201110.nc"
export STREAM_OFFSET=-21600

ATM_compute_tasks=${ATM_compute_tasks_cdeps_025}
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/datm_cdeps_restart_cfsr
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export LIST_FILES="RESTART/20111002.000000.MOM.res.nc \

export_datm_cdeps
export DATM_SRC=CFSR
export FILENAME_BASE=cfsr.
export FILEBASE_DATM=cfsr
export IATM=1760
export JATM=880
export FHMAX=24
Expand Down
6 changes: 3 additions & 3 deletions tests/tests/datm_cdeps_stochy_gefs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ export ATM_NX_GLB=$IATM
export ATM_NY_GLB=$JATM
export ATMRES=${IATM}x${JATM}
export DATM_SRC=GEFS_NEW
export FILENAME_BASE=gefs.
export MESH_ATM=${FILENAME_BASE//.}_mesh.nc
export stream_files="INPUT/${FILENAME_BASE}201110.nc"
export FILEBASE_DATM=gefs
export MESH_ATM=${FILEBASE_DATM}_mesh.nc
export stream_files="INPUT/${FILEBASE_DATM}.201110.nc"
export STREAM_OFFSET=-21600
export RESTART_N=12
export eps_imesh=2.5e-1
Expand Down