Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSSL MP update: documentation update and parameter name change #1775

Merged
merged 14 commits into from
Jul 5, 2023
Merged

NSSL MP update: documentation update and parameter name change #1775

merged 14 commits into from
Jul 5, 2023

Conversation

JiliDong-NOAA
Copy link
Contributor

@JiliDong-NOAA JiliDong-NOAA commented Jun 1, 2023 •
edited by zach1221
Loading

Description

This PR updates documentation for NSSL MP parameters and changes two parameter name.

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@grantfirl
Copy link
Collaborator

FYI, the CCPP physics PR that this references was combined with ufs-community/ccpp-physics#76 to try to save code management work, but I'm not 100% sure that the combined PR (ufs-community/ccpp-physics#76) should go in. We either need to resolve the conversation there about its status or ask the author of ufs-community/ccpp-physics#77 to de-combine the PRs if the conversation is not resolved soon.

@jkbk2004
Copy link
Collaborator

@JiliDong-NOAA Is regression test log available?

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA Is regression test log available?

@jkbk2004 I haven't done any regression test so far. Will start on Hera today.

@jkbk2004
Copy link
Collaborator

@JiliDong-NOAA Is regression test log available?

@jkbk2004 I haven't done any regression test so far. Will start on Hera today.

@JiliDong-NOAA sure! go ahead to attach the log to the pr description once the test is done.

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA Is regression test log available?

@jkbk2004 I haven't done any regression test so far. Will start on Hera today.

@JiliDong-NOAA sure! go ahead to attach the log to the pr description once the test is done.

It looks like ccpp-physics in this PR is not synced with the latest commit. Should I wait for it to get synced before trying RT? @jkbk2004 @MicroTed

@grantfirl
Copy link
Collaborator

@JiliDong-NOAA Yes, I think that ufs-community/ccpp-physics#77 needs to be updated to ufs/dev before you test. If @MicroTed is unavailable to do this, you can always manually merge in ufs/dev on the machine you're using before running rt.sh.

@JiliDong-NOAA
Copy link
Contributor Author

thanks @MicroTed @grantfirl . FV3 and ufs-weather-model have been synced as well. Regression tests are being running on Hera and WCOSS2. Orion is down today and I will try once it is back.

@jkbk2004
Copy link
Collaborator

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

it is still running. I am not sure if I use the right command: "rt.sh -l rt.conf"

@JiliDong-NOAA
Copy link
Contributor Author

got an error in RT hafs_regional_1nest_atm_qr_intel

Comparing RESTART/20200825.180000.sfc_data.nc ............ALT CHECK......ERROR

this is strange as this PR shouldn't change any forecast, particularly when NSSL MP is not used. Could this be a system issue? I will run an individual RT for hafs_regional_1nest_atm_qr_intel.

@JiliDong-NOAA
Copy link
Contributor Author

got an error in RT hafs_regional_1nest_atm_qr_intel

Comparing RESTART/20200825.180000.sfc_data.nc ............ALT CHECK......ERROR

this is strange as this PR shouldn't change any forecast, particularly when NSSL MP is not used. Could this be a system issue? I will run an individual RT for hafs_regional_1nest_atm_qr_intel.

The individual RT of hafs_regional_1nest_atm_qr passed OK. @jkbk2004 Is there any way to pick up from this failed RT test and resume? Restarting the whole suite of RTs will take another 20 hours to finish the first 138 RTs.

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jun 29, 2023 •
edited
Loading

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

it is still running. I am not sure if I use the right command: "rt.sh -l rt.conf"

@JiliDong-NOAA You did not use ecflow, which is why the test took so long. It ran each test sequentially. To run using ecflow, you need to log into the ecflow node (ssh hecflow01) and then use ./rt.sh -e -a ACCT >output 2>&1 &.

I use nems for ACCT. Yours may be different.

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA Can you attach hera test log? so we can move this pr forward.

it is still running. I am not sure if I use the right command: "rt.sh -l rt.conf"

@JiliDong-NOAA You did not use ecflow, which is why the test took so long. It ran each test sequentially. To run using ecflow, you need to log into the ecflow node (ssh hecflow01) and then use ./rt.sh -e -a ACCT >output 2>&1 &.

I use nems for ACCT. Yours may be different.

Ah I see. thanks @DeniseWorthen ! I will do as you suggested.

@JiliDong-NOAA
Copy link
Contributor Author

JiliDong-NOAA commented Jun 29, 2023 •
edited
Loading

RegressionTests_hera.log
RegressionTests_wcoss2.log
@jkbk2004 hera and wcoss2 rt logs uploaded.

@DeniseWorthen
Copy link
Collaborator

@JiliDong-NOAA Great. Brian tells me it is no longer required to log into an ecflow node, so you should be able to just skip that step.

@JiliDong-NOAA
Copy link
Contributor Author

@JiliDong-NOAA Great. Brian tells me it is no longer required to log into an ecflow node, so you should be able to just skip that step.

Thanks again @DeniseWorthen

@zach1221 zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jun 30, 2023
@zach1221
Copy link
Collaborator

@BrianCurtis-NOAA I'm adding this PR to the commit queue, and beginning testing.

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Jun 30, 2023
@zach1221
Copy link
Collaborator

Jenkins-ci attached. ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1775 #1 Console [Jenkins].pdf

@zach1221 zach1221 added cheyenne-RT hera-RT Run Hera regression testing and removed cheyenne-RT labels Jun 30, 2023
@zach1221 zach1221 added jet-RT Run AutoRT Jet regression testing and removed hera-RT Run Hera regression testing jet-RT Run AutoRT Jet regression testing labels Jun 30, 2023
@grantfirl grantfirl mentioned this pull request Jun 30, 2023
Merged
39 tasks
@zach1221
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1374260656/20230630140303/ufs-weather-model
Please make changes and add the following label back: cheyenne-RT

@zach1221
Copy link
Collaborator

zach1221 commented Jul 2, 2023

Testing is complete, we can begin the merging process. I'll follow up on the ccpp-physics sub-pr #77.

@zach1221 zach1221 mentioned this pull request Jul 2, 2023
Merged
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jul 5, 2023

@JiliDong-NOAA fv3 pr was merged. can you update submodule pointer and revert change in gitmodiles? New fv3 hash is NOAA-EMC/fv3atm@e1de62f

@JiliDong-NOAA
Copy link
Contributor Author

FV3 updated

@jkbk2004 jkbk2004 merged commit 24c51d1 into ufs-community:develop Jul 5, 2023
@MatthewMasarik-NOAA MatthewMasarik-NOAA mentioned this pull request Jul 5, 2023
Merged
37 tasks
@JiliDong-NOAA JiliDong-NOAA deleted the nssl_mp branch August 21, 2023 20:43
@grantfirl grantfirl mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@SadeghTabas-NOAA SadeghTabas-NOAA SadeghTabas-NOAA approved these changes

@DusanJovic-NOAA DusanJovic-NOAA Awaiting requested review from DusanJovic-NOAA

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

Assignees
No one assigned
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JiliDong-NOAA @grantfirl @jkbk2004 @DeniseWorthen @zach1221 @SadeghTabas-NOAA @BrianCurtis-NOAA @epic-cicd-jenkins